Page MenuHomeFreeBSD
Differential D58110

x86/local_apic.c: Factor out version read and max LVT slot computation
ClosedPublic
Actions

Authored by olce on Jul 8 2026, 1:14 PM.
Tags
None
Referenced Files
F166012919: D58110.id181718.diff
Tue, Aug 11, 1:04 AM
F166007178: D58110.id181539.diff
Mon, Aug 10, 11:44 PM
F165982617: D58110.id.diff
Mon, Aug 10, 7:46 PM
F165942223: D58110.id181549.diff
Mon, Aug 10, 4:04 PM
F165875218: D58110.id181539.diff
Mon, Aug 10, 9:42 AM
Unknown Object (File)
Sun, Aug 9, 11:46 AM
Unknown Object (File)
Sun, Aug 9, 3:50 AM
Unknown Object (File)
Sat, Aug 8, 11:04 PM
View All 40 Files
Subscribers
emaste
imp

Details

Reviewers
bnovkov
kib
Commits
rG93dbde154260: x86/local_apic.c: Factor out version read and max LVT slot computation
rGde606fe4fd1c: x86/local_apic.c: Factor out version read and max LVT slot computation
rG060ecf296664: x86/local_apic.c: Factor out version read and max LVT slot computation
Summary

This makes the code slightly more compact and easier to read.

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce created this revision.Jul 8 2026, 1:14 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 8 2026, 1:14 PM
olce requested review of this revision.Jul 8 2026, 1:14 PM
olce mentioned this in D58086: x86/local_apic.c: Fiddle with thermal LVT slot only if supported.Jul 8 2026, 1:14 PM
Harbormaster completed remote builds in B74620: Diff 181539.Jul 8 2026, 1:14 PM
olce updated this revision to Diff 181549.Jul 8 2026, 4:38 PM

Be consistent and declare all small helpers as inline.

olce added a reviewer: kib.Jul 8 2026, 4:38 PM
olce removed a subscriber: kib.
Harbormaster completed remote builds in B74626: Diff 181549.Jul 8 2026, 4:38 PM
bnovkov accepted this revision.Jul 8 2026, 8:30 PM
This revision is now accepted and ready to land.Jul 8 2026, 8:30 PM
kib added inline comments.Jul 9 2026, 5:08 AM
sys/x86/x86/local_apic.c
383

What is __const?

olce marked an inline comment as done.Jul 9 2026, 7:26 PM
olce added inline comments.
sys/x86/x86/local_apic.c
383

A mistake, I was thinking about the const attribute to functions. Replace by our __pure2 in my tree.

olce marked an inline comment as done.Jul 9 2026, 7:26 PM
Closed by commit rG060ecf296664: x86/local_apic.c: Factor out version read and max LVT slot computation (authored by olce). · Explain WhyJul 10 2026, 3:31 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rG060ecf296664: x86/local_apic.c: Factor out version read and max LVT slot computation.
olce added a commit: rGde606fe4fd1c: x86/local_apic.c: Factor out version read and max LVT slot computation.Thu, Jul 23, 10:02 AM
olce added a commit: rG93dbde154260: x86/local_apic.c: Factor out version read and max LVT slot computation.Fri, Jul 24, 4:35 AM

Revision Contents
Changeset List

PathSize
sys/
x86/
x86/
72 lines

Diff 181718

View Options

sys/x86/x86/local_apic.c

Loading...