Page MenuHomeFreeBSD

netlink: Use unsigned type in nl_process_nbuf
ClosedPublic

Authored by emaste on Jun 5 2026, 7:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 25, 4:53 PM
Unknown Object (File)
Sat, Jul 25, 3:46 PM
Unknown Object (File)
Thu, Jul 16, 1:46 AM
Unknown Object (File)
Wed, Jul 15, 7:25 AM
Unknown Object (File)
Wed, Jul 15, 7:25 AM
Unknown Object (File)
Wed, Jul 1, 10:51 PM
Unknown Object (File)
Jun 25 2026, 7:48 AM
Unknown Object (File)
Jun 25 2026, 7:28 AM

Details

Summary

nlmsghdr::nlmsg_len and nl_buf::offset are u_int. Make msglen match.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Jun 5 2026, 7:20 PM
This revision is now accepted and ready to land.Jun 5 2026, 7:24 PM
glebius requested changes to this revision.Jun 8 2026, 6:03 PM

Original Netlink submission had a ton of violations like that and we are slowly but surely fixing them.

sys/netlink/netlink_io.c
347–352

While here I'd suggest to bring this to style.

This revision now requires changes to proceed.Jun 8 2026, 6:03 PM

var declaration at top of block

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2026, 7:52 PM
This revision was automatically updated to reflect the committed changes.