Page MenuHomeFreeBSD

netlink: Use unsigned type in nl_process_nbuf
ClosedPublic

Authored by emaste on Fri, Jun 5, 7:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 1, 10:51 PM
Unknown Object (File)
Thu, Jun 25, 7:48 AM
Unknown Object (File)
Thu, Jun 25, 7:28 AM
Unknown Object (File)
Thu, Jun 25, 5:55 AM
Unknown Object (File)
Thu, Jun 25, 5:37 AM
Unknown Object (File)
Wed, Jun 24, 10:46 PM
Unknown Object (File)
Sun, Jun 21, 3:13 PM
Unknown Object (File)
Sun, Jun 21, 3:11 PM

Details

Summary

nlmsghdr::nlmsg_len and nl_buf::offset are u_int. Make msglen match.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Fri, Jun 5, 7:20 PM
This revision is now accepted and ready to land.Fri, Jun 5, 7:24 PM
glebius requested changes to this revision.Mon, Jun 8, 6:03 PM

Original Netlink submission had a ton of violations like that and we are slowly but surely fixing them.

sys/netlink/netlink_io.c
347–352

While here I'd suggest to bring this to style.

This revision now requires changes to proceed.Mon, Jun 8, 6:03 PM

var declaration at top of block

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Jun 8, 7:52 PM
This revision was automatically updated to reflect the committed changes.