Page MenuHomeFreeBSD

netlink: Use unsigned type in nl_process_nbuf
ClosedPublic

Authored by emaste on Jun 5 2026, 7:20 PM.
Tags
None
Referenced Files
F167042326: D57474.id179292.diff
Tue, Aug 18, 6:10 PM
F167041327: D57474.id179401.diff
Tue, Aug 18, 5:54 PM
Unknown Object (File)
Tue, Aug 18, 3:19 AM
Unknown Object (File)
Sun, Aug 16, 4:49 PM
Unknown Object (File)
Thu, Aug 13, 1:36 AM
Unknown Object (File)
Wed, Aug 12, 11:44 PM
Unknown Object (File)
Tue, Aug 11, 8:02 PM
Unknown Object (File)
Tue, Aug 11, 1:35 PM

Details

Summary

nlmsghdr::nlmsg_len and nl_buf::offset are u_int. Make msglen match.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Jun 5 2026, 7:20 PM
This revision is now accepted and ready to land.Jun 5 2026, 7:24 PM
glebius requested changes to this revision.Jun 8 2026, 6:03 PM

Original Netlink submission had a ton of violations like that and we are slowly but surely fixing them.

sys/netlink/netlink_io.c
347–352

While here I'd suggest to bring this to style.

This revision now requires changes to proceed.Jun 8 2026, 6:03 PM

var declaration at top of block

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2026, 7:52 PM
This revision was automatically updated to reflect the committed changes.