tests/net: Run all tests with execenv=jail and enable parallelism
ClosedPublic
Actions

Authored by markj on Tue, May 19, 3:23 PM.

Details

Reviewers

pouria

Group Reviewers

network

Commits

rG6ab30433a73b: tests/net: Run all tests with execenv=jail and enable parallelism

Summary

This has been stable in my testing, and enabling parallelism speeds up
test runs considerably. In particular, with -v parallelism=16 in a
16-vcpu bhyve VM my test runs go from ~50m to ~40m; the exact numbers
depend on the kernel config in use.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Tue, May 19, 3:23 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptTue, May 19, 3:23 PM

markj requested review of this revision.Tue, May 19, 3:23 PM

Harbormaster completed remote builds in B73226: Diff 178110.Tue, May 19, 3:23 PM

After @zlei work on VNET. I think it's better to remove is_exclusive=true.
Tested, LGTM

This revision is now accepted and ready to land.Wed, May 20, 9:57 AM

In D57094#1308941, @pouria wrote:

After @zlei work on VNET. I think it's better to remove is_exclusive=true.
Tested, LGTM

Looks good to disable is_exclusive right now. Please let me know if new panic occurs.

BTW, all network related tests shall run great with execenv=jail ( vnet jail ). The vnet jail is naturally a good mean to isolate those network related tests.

Closed by commit rG6ab30433a73b: tests/net: Run all tests with execenv=jail and enable parallelism (authored by markj). · Explain WhyFri, May 22, 2:54 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG6ab30433a73b: tests/net: Run all tests with execenv=jail and enable parallelism.