Page MenuHomeFreeBSD

tcp/lro: Return TCP_LRO_NO_ENTRIES if we are short of LRO entries.
ClosedPublic

Authored by sepherosa_gmail.com on Mar 21 2016, 8:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 12, 8:33 PM
Unknown Object (File)
Tue, May 5, 5:48 AM
Unknown Object (File)
Mon, May 4, 9:52 AM
Unknown Object (File)
Thu, Apr 30, 6:36 AM
Unknown Object (File)
Tue, Apr 28, 12:04 PM
Unknown Object (File)
Mon, Apr 27, 3:18 AM
Unknown Object (File)
Sun, Apr 26, 4:19 PM
Unknown Object (File)
Sun, Apr 19, 3:22 AM
Subscribers
None

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com retitled this revision from to tcp/lro: Return TCP_LRO_NO_ENTRIES if we are short of LRO entries..
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)

I have no objection.

However, if you can use the RSS-sorted LRO lro_queue_mbuf() interface, then this should never be a problem.

I have no objection.

However, if you can use the RSS-sorted LRO lro_queue_mbuf() interface, then this should never be a problem.

The difficult part is to pick up a proper mbuf limit, so that we can aggregate "just enough segments/ACKs" per connection under various loads. In the Hyper-V, aggregating too many segments will cause problem like ACK's timeliness, but aggregating not enough segments will waste precious cpu time (virtual cpu is slow).

Well, at least returning a different value does hurt here :)

I plan to commit it tomorrow.

This revision was automatically updated to reflect the committed changes.