Page MenuHomeFreeBSD

tcp/lro: Return TCP_LRO_NO_ENTRIES if we are short of LRO entries.
ClosedPublic

Authored by sepherosa_gmail.com on Mar 21 2016, 8:53 AM.
Tags
None
Referenced Files
F137368149: D5695.diff
Sat, Nov 22, 8:25 PM
Unknown Object (File)
Sat, Nov 22, 2:22 PM
Unknown Object (File)
Fri, Nov 21, 6:17 AM
Unknown Object (File)
Fri, Nov 21, 6:15 AM
Unknown Object (File)
Fri, Nov 21, 6:02 AM
Unknown Object (File)
Fri, Nov 21, 6:02 AM
Unknown Object (File)
Thu, Nov 20, 1:28 PM
Unknown Object (File)
Mon, Nov 17, 8:25 PM
Subscribers
None

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com retitled this revision from to tcp/lro: Return TCP_LRO_NO_ENTRIES if we are short of LRO entries..
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)

I have no objection.

However, if you can use the RSS-sorted LRO lro_queue_mbuf() interface, then this should never be a problem.

I have no objection.

However, if you can use the RSS-sorted LRO lro_queue_mbuf() interface, then this should never be a problem.

The difficult part is to pick up a proper mbuf limit, so that we can aggregate "just enough segments/ACKs" per connection under various loads. In the Hyper-V, aggregating too many segments will cause problem like ACK's timeliness, but aggregating not enough segments will waste precious cpu time (virtual cpu is slow).

Well, at least returning a different value does hurt here :)

I plan to commit it tomorrow.

This revision was automatically updated to reflect the committed changes.