Page MenuHomeFreeBSD
Differential D56863

vm_map_growstack(): give a hint to user that stack was blown out
ClosedPublic
Actions

Authored by kib on Wed, May 6, 10:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 23, 12:29 AM
Unknown Object (File)
Fri, May 22, 10:55 AM
Unknown Object (File)
Fri, May 22, 1:01 AM
Unknown Object (File)
Thu, May 21, 8:52 PM
Unknown Object (File)
Thu, May 21, 7:00 PM
Unknown Object (File)
Wed, May 20, 9:54 AM
Unknown Object (File)
Mon, May 18, 7:08 AM
Unknown Object (File)
Sun, May 17, 3:25 PM
View All 31 Files
Subscribers
imp

Details

Reviewers
alc
markj
Commits
rG18c5a26f8a74: vm_map_growstack(): give a hint to user that stack was blown out
rG642dd17ee943: vm_map_growstack(): consistently use local vars instead of curthread/proc

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Wed, May 6, 10:56 PM
Herald added a subscriber: imp. · View Herald TranscriptWed, May 6, 10:56 PM
kib requested review of this revision.Wed, May 6, 10:56 PM
kib added reviewers: alc, markj.Wed, May 6, 11:57 PM

RACCT cases are excluded for the reason, they are self-inflicted.

markj added inline comments.Thu, May 7, 3:52 PM
sys/vm/vm_map.c
4801

Is it worth including the thread ID too?

kib marked an inline comment as done.Thu, May 7, 4:02 PM
kib added inline comments.
sys/vm/vm_map.c
4801

I thought about that, and eventually decided not to, because usually the program is killed. But since you asked, lets add it.

kib updated this revision to Diff 177368.Thu, May 7, 4:03 PM
kib marked an inline comment as done.

Print tid.
Consistently use a local variable instead of curproc.

markj accepted this revision.Thu, May 7, 4:13 PM
This revision is now accepted and ready to land.Thu, May 7, 4:13 PM
Closed by commit rG642dd17ee943: vm_map_growstack(): consistently use local vars instead of curthread/proc (authored by kib). · Explain WhyThu, May 7, 5:01 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG642dd17ee943: vm_map_growstack(): consistently use local vars instead of curthread/proc.
kib added a commit: rG18c5a26f8a74: vm_map_growstack(): give a hint to user that stack was blown out.
alc added inline comments.Thu, May 7, 5:07 PM
sys/vm/vm_map.c
4759

In the same vein as your second commit, this could use vm instead of spelling it out as p->p_vmspace.

Revision Contents
Changeset List

PathSize
sys/
vm/
14 lines

Diff 177371

View Options

sys/vm/vm_map.c

Loading...