Page MenuHomeFreeBSD
Differential D56606

tests/net/if_clone_test: Add a test for races between if_detach() and if_vmove_reclaim()
ClosedPublic
Actions

Authored by zlei on Thu, Apr 23, 6:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 30, 2:04 AM
Unknown Object (File)
Wed, Apr 29, 9:43 AM
Unknown Object (File)
Wed, Apr 29, 6:59 AM
Unknown Object (File)
Tue, Apr 28, 12:13 PM
Unknown Object (File)
Tue, Apr 28, 11:27 AM
Unknown Object (File)
Tue, Apr 28, 5:38 AM
Unknown Object (File)
Sat, Apr 25, 6:05 AM
Subscribers
ae
glebius
imp
melifaro

Details

Reviewers
kp
Group Reviewers
network
Commits
rG696d1590697e: tests/net/if_clone_test: Add a test for races between if_detach() and…
rGf4be16983dea: tests/net/if_clone_test: Add a test for races between if_detach() and…
Summary

Ideally we shall have tests for all possible races, that is races
between if_detach(), if_vmove_loan(), if_vmove_reclaim() and
vnet_if_return(). But that requires too many tests and it appears to
be less valuable to have them all. So focus on recent fixes [1] and [2].

[1] ee9456ce3753 ifnet: Fix races in if_vmove_reclaim()
[2] D56374 ifnet: if_detach(): Fix races with if_vmove()

MFC after: 5 days

Test Plan

Current requires extra effort du to virtualization of bpf. Run against stable/15 or stable/14 instead.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Thu, Apr 23, 6:55 PM
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptThu, Apr 23, 6:55 PM
zlei requested review of this revision.Thu, Apr 23, 6:55 PM
zlei added inline comments.
tests/sys/net/if_clone_test.sh
125

This test will surely cleanup the clone created epair interfaces by it self. Seems no need for cleanup_ifaces. Please correct me if wrong.

zlei mentioned this in D56374: ifnet: if_detach(): Fix races with if_vmove().Thu, Apr 23, 9:04 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Apr 27, 7:21 PM
Closed by commit rGf4be16983dea: tests/net/if_clone_test: Add a test for races between if_detach() and… (authored by zlei). · Explain Why
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rGf4be16983dea: tests/net/if_clone_test: Add a test for races between if_detach() and….
zlei added a commit: rG696d1590697e: tests/net/if_clone_test: Add a test for races between if_detach() and….Thu, Apr 30, 9:54 AM

Revision Contents
Changeset List

PathSize
tests/
sys/
net/
29 lines

Diff 176664

View Options

tests/sys/net/if_clone_test.sh

Loading...