Page MenuHomeFreeBSD
Differential D56582

linuxkpi: Add `pci_dev_is_disconnected()`
ClosedPublic
Actions

Authored by dumbbell on Wed, Apr 22, 6:56 PM.
Tags
None
Referenced Files
F153987297: D56582.id176166.diff
Sat, Apr 25, 6:49 AM
F153974395: D56582.id176142.diff
Sat, Apr 25, 5:10 AM
F153974281: D56582.id176153.diff
Sat, Apr 25, 5:10 AM
F153969604: D56582.id176156.diff
Sat, Apr 25, 4:31 AM
Unknown Object (File)
Fri, Apr 24, 4:58 AM
Subscribers
bz
emaste
imp

Details

Reviewers
bz
Group Reviewers
linuxkpi
Commits
rG43b47418e769: linuxkpi: Add `pci_dev_is_disconnected()`
Summary

For now, it is an empty stub that always return false. On Linux, it looks at an internal error state of the device to determine if it is disconnected.

The amdgpu DRM driver started this in Linux 6.12.x.

This is part of the update of DRM drivers to Linux 6.12.81.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dumbbell created this revision.Wed, Apr 22, 6:56 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptWed, Apr 22, 6:56 PM
dumbbell requested review of this revision.Wed, Apr 22, 6:56 PM
dumbbell added a parent revision: D56577: linuxkpi: Add `rb_add()`.Wed, Apr 22, 7:01 PM
dumbbell added a child revision: D56583: linuxkpi: Define `min_array()` and `max_array()`.
bz requested changes to this revision.Wed, Apr 22, 7:10 PM
bz added a subscriber: bz.
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/pci.h
1339

I think this one warrants a pr_debug("TODO: %s\n", func);

This revision now requires changes to proceed.Wed, Apr 22, 7:10 PM
dumbbell updated this revision to Diff 176153.Wed, Apr 22, 7:31 PM

Address comment from @bz

dumbbell marked an inline comment as done.Wed, Apr 22, 7:31 PM
dumbbell updated this revision to Diff 176156.Wed, Apr 22, 7:37 PM

Fix compile error

bz accepted this revision.Wed, Apr 22, 7:58 PM
This revision is now accepted and ready to land.Wed, Apr 22, 7:58 PM
Closed by commit rG43b47418e769: linuxkpi: Add `pci_dev_is_disconnected()` (authored by dumbbell). · Explain WhyWed, Apr 22, 8:48 PM
This revision was automatically updated to reflect the committed changes.
dumbbell added a commit: rG43b47418e769: linuxkpi: Add `pci_dev_is_disconnected()`.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
7 lines

Diff 176166

View Options

sys/compat/linuxkpi/common/include/linux/pci.h

Loading...