Page MenuHomeFreeBSD

i386+gcc: gcc12 is the minimum version
Needs ReviewPublic

Authored by imp on Wed, Apr 15, 2:39 PM.
Tags
None
Referenced Files
F153386820: D56412.diff
Mon, Apr 20, 8:57 PM
Unknown Object (File)
Mon, Apr 20, 5:34 AM
Unknown Object (File)
Sun, Apr 19, 9:52 AM
Unknown Object (File)
Sun, Apr 19, 8:04 AM
Unknown Object (File)
Sat, Apr 18, 5:25 AM
Unknown Object (File)
Sat, Apr 18, 4:51 AM
Unknown Object (File)
Sat, Apr 18, 4:40 AM
Unknown Object (File)
Fri, Apr 17, 3:08 AM

Details

Reviewers
jhb
Summary

No need to make this more complex it needs to be. Assume gcc 12 or newer
and resort.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72228
Build 69111: arc lint + arc unit

Event Timeline

imp requested review of this revision.Wed, Apr 15, 2:39 PM
imp created this revision.
minsoochoo0122_proton.me added inline comments.
sys/conf/kern.mk
108

I see more of this kind in this file, but it can be done later as janitor work

So this isn't i386-specific at all (so the title is misleading), and is more about collapsing the conditionals for warnings on older compiler versions. If we want to do this (collapsing old versions), we should do it for userspace in bsd.sys.mk as well to be consistent I think. Though that gets a bit messier since there are ports that might use bsd.*.mk and USE_GCC. I do prefer to keep bsd.sys.mk and this file in sync as much as possible though, so if we keep the list of old versions in bsd.sys.mk we should keep them split out here as well. I wonder what the oldest version of GCC (lang/gcc*, not devel/freebsd-gcc*) supported in ports is at this point.