i386: locore.S includes this, so exclude C
AcceptedPublic
Actions

Authored by imp on Apr 15 2026, 2:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jul 5, 9:06 AM

	Unknown Object (File)
	Wed, Jun 24, 7:56 AM

	Unknown Object (File)
	Wed, Jun 24, 2:22 AM

	Unknown Object (File)
	Sat, Jun 20, 12:42 AM

	Unknown Object (File)
	Jun 1 2026, 3:34 PM

	Unknown Object (File)
	May 25 2026, 8:15 AM

	Unknown Object (File)
	May 25 2026, 8:11 AM

	Unknown Object (File)
	May 19 2026, 6:57 PM

View All 30 Files

Subscribers

None

Details

Reviewers

jhb

Summary

This is included by both C and assembler code, so exclude the C
definition from locore.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72226
Build 69109: arc lint + arc unit

Event Timeline

imp requested review of this revision.Apr 15 2026, 2:39 PM

imp created this revision.

Harbormaster completed remote builds in B72226: Diff 175571.Apr 15 2026, 2:39 PM

imp added a parent revision: D56409: kern: don't make pointer/int casting fatal.Apr 15 2026, 2:39 PM

imp added a child revision: D56411: i386: mark the stack as non-executable.

imp added a reviewer: jhb.Apr 15 2026, 2:41 PM

This should be just as broken for LLVM? Presumably this is a recent regression?

This revision is now accepted and ready to land.Apr 15 2026, 3:01 PM

I didn't check to see when this regressed. And I didn't do a llvm build (though I should) w/o it.

Revision Contents
Changeset List

Path

Size

sys/

x86/

include/

cputypes.h

2 lines

Diff 175571

View Options

sys/x86/include/cputypes.h

i386: locore.S includes this, so exclude CAcceptedPublicActions