Page MenuHomeFreeBSD
Differential D56410

i386: locore.S includes this, so exclude C
AcceptedPublic
Actions

Authored by imp on Apr 15 2026, 2:39 PM.
Tags
None
Referenced Files
F172341312: D56410.diff
Thu, Sep 17, 8:33 PM
Unknown Object (File)
Thu, Sep 10, 9:10 PM
Unknown Object (File)
Wed, Sep 9, 2:21 PM
Unknown Object (File)
Tue, Sep 8, 1:55 AM
Unknown Object (File)
Sun, Sep 6, 4:08 PM
Unknown Object (File)
Sun, Sep 6, 3:20 PM
Unknown Object (File)
Sun, Sep 6, 10:35 AM
Unknown Object (File)
Sat, Sep 5, 10:47 AM
View All 63 Files
Subscribers
None

Details

Reviewers
jhb
Summary

This is included by both C and assembler code, so exclude the C
definition from locore.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72226
Build 69109: arc lint + arc unit

Event Timeline

imp requested review of this revision.Apr 15 2026, 2:39 PM
imp created this revision.
Harbormaster completed remote builds in B72226: Diff 175571.Apr 15 2026, 2:39 PM
imp added a parent revision: D56409: kern: don't make pointer/int casting fatal.Apr 15 2026, 2:39 PM
imp added a child revision: D56411: i386: mark the stack as non-executable.
imp added a reviewer: jhb.Apr 15 2026, 2:41 PM
jhb accepted this revision.Apr 15 2026, 3:01 PM

This should be just as broken for LLVM? Presumably this is a recent regression?

This revision is now accepted and ready to land.Apr 15 2026, 3:01 PM
imp added a comment.Apr 15 2026, 4:03 PM

I didn't check to see when this regressed. And I didn't do a llvm build (though I should) w/o it.

Revision Contents
Changeset List

PathSize
sys/
x86/
include/
2 lines

Diff 175571

View Options

sys/x86/include/cputypes.h

Loading...