Page MenuHomeFreeBSD
Differential D56410

i386: locore.S includes this, so exclude C
AcceptedPublic
Actions

Authored by imp on Wed, Apr 15, 2:39 PM.
Tags
None
Referenced Files
F152988687: D56410.diff
Sat, Apr 18, 12:14 PM
F152935852: D56410.diff
Sat, Apr 18, 4:37 AM
Unknown Object (File)
Fri, Apr 17, 9:49 AM
Subscribers
None

Details

Reviewers
jhb
Summary

This is included by both C and assembler code, so exclude the C
definition from locore.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72226
Build 69109: arc lint + arc unit

Event Timeline

imp requested review of this revision.Wed, Apr 15, 2:39 PM
imp created this revision.
Harbormaster completed remote builds in B72226: Diff 175571.Wed, Apr 15, 2:39 PM
imp added a parent revision: D56409: kern: don't make pointer/int casting fatal.Wed, Apr 15, 2:39 PM
imp added a child revision: D56411: i386: mark the stack as non-executable.
imp added a reviewer: jhb.Wed, Apr 15, 2:41 PM
jhb accepted this revision.Wed, Apr 15, 3:01 PM

This should be just as broken for LLVM? Presumably this is a recent regression?

This revision is now accepted and ready to land.Wed, Apr 15, 3:01 PM
imp added a comment.Wed, Apr 15, 4:03 PM

I didn't check to see when this regressed. And I didn't do a llvm build (though I should) w/o it.

Revision Contents
Changeset List

PathSize
sys/
x86/
include/
2 lines

Diff 175571

View Options

sys/x86/include/cputypes.h

Loading...