ipfw: skip tests if required sysctl is not set
ClosedPublic
Actions

Authored by olivier on Mar 24 2026, 11:31 PM.

Tags

None

Referenced Files

	F172519652: D56069.id.diff
	Sat, Sep 19, 12:21 AM

	Unknown Object (File)
	Wed, Sep 16, 12:10 AM

	Unknown Object (File)
	Mon, Sep 14, 8:38 PM

	Unknown Object (File)
	Fri, Sep 11, 8:53 AM

	Unknown Object (File)
	Wed, Sep 9, 8:38 PM

	Unknown Object (File)
	Wed, Sep 9, 4:47 AM

	Unknown Object (File)
	Tue, Sep 1, 10:55 AM

	Unknown Object (File)
	Mon, Aug 24, 7:59 PM

View All 77 Files

Subscribers

imp

melifaro

vegeta_tuxpowered.net

zlei

Details

Reviewers

ae
glebius
zlei

Group Reviewers

network

Commits

rG648d0fefd757: ipfw: skip tests if required sysctl is not set

Summary

Instead of returning a failure, skip the test when the necessary sysctl is not set.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olivier created this revision.Mar 24 2026, 11:31 PM

Herald added subscribers: vegeta_tuxpowered.net, melifaro. · View Herald TranscriptMar 24 2026, 11:31 PM

olivier requested review of this revision.Mar 24 2026, 11:31 PM

glebius accepted this revision.Mar 25 2026, 4:30 AM

This revision is now accepted and ready to land.Mar 25 2026, 4:30 AM

Reasonable !

Closed by commit rG648d0fefd757: ipfw: skip tests if required sysctl is not set (authored by olivier). · Explain WhyMar 25 2026, 3:58 PM

This revision was automatically updated to reflect the committed changes.

olivier added a commit: rG648d0fefd757: ipfw: skip tests if required sysctl is not set.

Herald added a subscriber: imp. · View Herald TranscriptMar 25 2026, 3:58 PM

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

common/

utils.subr

2 lines

Diff 174295

View Options

tests/sys/netpfil/common/utils.subr

ipfw: skip tests if required sysctl is not setClosedPublicActions