Differential D55173
uart: Add ns8250 ACPI entry for SPCR rev 2 Authored by cperciva on Sun, Feb 8, 12:45 AM. Tags None Referenced Files
Subscribers None
Details This is an MFC "in spirit" of a685a263b803; the code in this area has Tested by: David Woodhouse
Diff Detail
Event TimelineComment Actions There's also a 'honor disabled ports' commit in main that you may want to merge too... Comment Actions commit d82698ac68c23d856716dc9f6524b9ef363d7eba loader.efi: Only use SPCR if enabled. SerialPort in the SPCR is zeroed when serial redirection is disabled, rather than the SPCR being omitted from the ACPI tables ony many systems. Check to see that SerialPort.Address is non-zero before using. FreeBSD would fail to boot on systems that could have a serial port redireciton, but don't have it enabled because the loader would create a bogus hw.uart.console. While one could unset this value to boot, you couldn't do that automatically very easily. Instead, don't even look at the SPCR table if the SerialPort is zero'd. PR: 292206 MFC After: 3 days Sponsored by: Netflix Co-authored-by: Warner Losh <imp@FreeBSD.org> Closes: https://github.com/freebsd/freebsd-src/pull/1948 Comment Actions Ah thanks, I was looking in the kernel uart code. It looks like the code to use SPCR in the boot loader was never MFCed so there's no need for a bug fix to it. :-) |