diff: Don't compare a file or directory to itself
ClosedPublic
Actions

Authored by des on Wed, Feb 4, 6:35 PM.

Details

Reviewers

thj
kevans

Group Reviewers

Klara

Commits

rG590126789c84: diff: Don't compare a file or directory to itself

Summary

While here, stop abusing struct dirent for something we don't even need
to store.

PR: 254455
MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Wed, Feb 4, 6:35 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Feb 4, 6:35 PM

des requested review of this revision.Wed, Feb 4, 6:35 PM

des added a parent revision: D55112: diff: Fix pagination leak.

Harbormaster completed remote builds in B70412: Diff 171168.Wed, Feb 4, 6:35 PM

thj accepted this revision.Thu, Feb 5, 1:01 PM

This revision is now accepted and ready to land.Thu, Feb 5, 1:01 PM

kevans accepted this revision.Thu, Feb 5, 2:28 PM

Closed by commit rG590126789c84: diff: Don't compare a file or directory to itself (authored by des). · Explain WhyThu, Feb 5, 2:46 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG590126789c84: diff: Don't compare a file or directory to itself.

Revision Contents
Changeset List

Path

Size

usr.bin/

diff/

diffdir.c

14 lines

diffreg.c

3 lines

tests/

diff_test.sh

19 lines

Diff 171223

View Options

usr.bin/diff/diffdir.c

View Options

usr.bin/diff/diffreg.c

View Options

usr.bin/diff/tests/diff_test.sh

diff: Don't compare a file or directory to itselfClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 171223

usr.bin/diff/diffdir.c

usr.bin/diff/diffreg.c

usr.bin/diff/tests/diff_test.sh

diff: Don't compare a file or directory to itself
ClosedPublic
Actions

Revision Contents
Changeset List