Page MenuHomeFreeBSD
Differential D55111

diff: Add test case for pagination resource leak
ClosedPublic
Actions

Authored by des on Wed, Feb 4, 6:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 11, 4:00 PM
Unknown Object (File)
Wed, Feb 11, 5:36 AM
Unknown Object (File)
Wed, Feb 11, 12:26 AM
Unknown Object (File)
Wed, Feb 11, 12:25 AM
Unknown Object (File)
Tue, Feb 10, 9:54 PM
Unknown Object (File)
Tue, Feb 10, 9:01 PM
Unknown Object (File)
Tue, Feb 10, 7:25 PM
Subscribers
imp

Details

Reviewers
thj
kevans
Group Reviewers
Klara
Commits
rG2434f3b279a9: diff: Add test case for pagination resource leak
rGf0852209a086: diff: Add test case for pagination resource leak
rG51c2384ce049: diff: Add test case for pagination resource leak
rGa0a37c2143e8: diff: Add test case for pagination resource leak
rG270492602b9b: diff: Add test case for pagination resource leak
Summary

The pagination code leaks either processes or descriptors or both,
depending on the exact version of the code you have. Add a test case
which exercises this leak to facilitate fixing it.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Wed, Feb 4, 6:35 PM
Herald added a subscriber: imp. · View Herald TranscriptWed, Feb 4, 6:35 PM
des requested review of this revision.Wed, Feb 4, 6:35 PM
Harbormaster completed remote builds in B70410: Diff 171166.Wed, Feb 4, 6:35 PM
des added a parent revision: D55110: diff: Fix integer overflows in Stone algorithm.Wed, Feb 4, 6:35 PM
des added a child revision: D55112: diff: Fix pagination leak.
thj accepted this revision.Thu, Feb 5, 1:03 PM
This revision is now accepted and ready to land.Thu, Feb 5, 1:03 PM
kevans accepted this revision.Thu, Feb 5, 2:23 PM
Closed by commit rG270492602b9b: diff: Add test case for pagination resource leak (authored by des). · Explain WhyThu, Feb 5, 2:46 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG270492602b9b: diff: Add test case for pagination resource leak.
des added a commit: rGa0a37c2143e8: diff: Add test case for pagination resource leak.Tue, Feb 10, 3:28 PM
des added a commit: rG51c2384ce049: diff: Add test case for pagination resource leak.
des added a commit: rGf0852209a086: diff: Add test case for pagination resource leak.Tue, Feb 10, 3:33 PM
cperciva added a commit: rG2434f3b279a9: diff: Add test case for pagination resource leak.Wed, Feb 11, 6:15 AM

Revision Contents
Changeset List

PathSize
usr.bin/
diff/
tests/
22 lines

Diff 171221

View Options

usr.bin/diff/tests/diff_test.sh

Loading...