diff: Fix integer overflows in Stone algorithm
ClosedPublic
Actions

Authored by des on Wed, Feb 4, 6:35 PM.

Details

Reviewers

thj
kevans

Group Reviewers

Klara

Commits

rG5fc739eb5949: diff: Fix integer overflows in Stone algorithm

Summary

Fix integer overflows that may occur when the context window is very
large and add tests to exercise those conditions.

PR: 267032
MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Wed, Feb 4, 6:35 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Feb 4, 6:35 PM

des requested review of this revision.Wed, Feb 4, 6:35 PM

des added a parent revision: D55109: diff: Print an error message on I/O error.

Harbormaster completed remote builds in B70409: Diff 171165.Wed, Feb 4, 6:35 PM

des added a child revision: D55111: diff: Add test case for pagination resource leak.Wed, Feb 4, 6:35 PM

thj accepted this revision.Thu, Feb 5, 1:01 PM

This revision is now accepted and ready to land.Thu, Feb 5, 1:01 PM

kevans accepted this revision.Thu, Feb 5, 2:23 PM

Closed by commit rG5fc739eb5949: diff: Fix integer overflows in Stone algorithm (authored by des). · Explain WhyThu, Feb 5, 2:46 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG5fc739eb5949: diff: Fix integer overflows in Stone algorithm.

Revision Contents
Changeset List

Path

Size

usr.bin/

diff/

diffreg.c

32 lines

tests/

diff_test.sh

33 lines

Diff 171220

View Options

usr.bin/diff/diffreg.c