Differential D55098

libfetch: Check for failure to create SSL context
ClosedPublic
Actions

Authored by des on Feb 4 2026, 10:36 AM.

Tags

None

Referenced Files

	F159335524: D55098.id171406.diff
	Fri, Jun 12, 11:52 PM

	Unknown Object (File)
	Wed, Jun 10, 8:39 PM

	Unknown Object (File)
	May 11 2026, 7:17 PM

	Unknown Object (File)
	May 11 2026, 7:16 PM

	Unknown Object (File)
	May 11 2026, 7:06 PM

	Unknown Object (File)
	May 8 2026, 10:44 PM

	Unknown Object (File)
	May 8 2026, 3:36 PM

	Unknown Object (File)
	May 3 2026, 3:55 AM

View All 22 Files

Subscribers

Details

Reviewers

Commits

rG53e0a1d1ff9b: libfetch: Check for failure to create SSL context
rG767f1ebcf75e: libfetch: Check for failure to create SSL context
rG4781aeb5b9cb: libfetch: Check for failure to create SSL context
rGd653f474e901: libfetch: Check for failure to create SSL context
rG4e160c6197f7: libfetch: Check for failure to create SSL context

Summary

Drop the ssl_meth member, there is no reason to hang on to it.

Replace deprecated SSLv23_client_method() with TLS_client_method().

Check the return value from SSL_CTX_new().

MFC after: 1 week
PR: 292903

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Feb 4 2026, 10:36 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 4 2026, 10:36 AM

des requested review of this revision.Feb 4 2026, 10:36 AM

Harbormaster completed remote builds in B70393: Diff 171134.Feb 4 2026, 10:36 AM

markj accepted this revision.Feb 7 2026, 1:59 PM

This revision is now accepted and ready to land.Feb 7 2026, 1:59 PM

Closed by commit rG4e160c6197f7: libfetch: Check for failure to create SSL context (authored by des). · Explain WhyFeb 7 2026, 2:25 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG4e160c6197f7: libfetch: Check for failure to create SSL context.

des added a commit: rGd653f474e901: libfetch: Check for failure to create SSL context.Feb 11 2026, 8:40 PM

des added a commit: rG4781aeb5b9cb: libfetch: Check for failure to create SSL context.

des added a commit: rG767f1ebcf75e: libfetch: Check for failure to create SSL context.Feb 11 2026, 8:42 PM

cperciva added a commit: rG53e0a1d1ff9b: libfetch: Check for failure to create SSL context.Feb 12 2026, 9:25 PM

Revision Contents
Changeset List

Path

Size

lib/

libfetch/

1 line

10 lines

Diff 171406

lib/libfetch/common.h

Loading...

lib/libfetch/common.c

Loading...