Differential D54580

ipfw: remove locking workarounds in the table code
Needs ReviewPublic
Actions

Authored by glebius on Wed, Jan 7, 5:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 8, 6:09 AM

	Unknown Object (File)
	Thu, Jan 8, 4:20 AM

	Unknown Object (File)
	Thu, Jan 8, 2:43 AM

	Unknown Object (File)
	Thu, Jan 8, 12:53 AM

	Unknown Object (File)
	Thu, Jan 8, 12:21 AM

	Unknown Object (File)
	Wed, Jan 7, 10:56 PM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

ae
melifaro
lytboris_gmail.com

Group Reviewers

Summary

Before the "upper half lock" became sleepable the table manipulation code
needed sophisticated workarounds to recover from races, where the lock is
temporarily dropped to do malloc(M_WAITOK). Remove all these workarounds
as they are no longer needed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69689
Build 66572: arc lint + arc unit

Event Timeline

glebius created this revision.Wed, Jan 7, 5:41 PM

Herald added subscribers: vegeta_tuxpowered.net, donner, imp. · View Herald TranscriptWed, Jan 7, 5:41 PM

glebius requested review of this revision.Wed, Jan 7, 5:41 PM

glebius added a parent revision: D54535: ipfw: make the upper half lock sleepable.

Harbormaster completed remote builds in B69689: Diff 169256.Wed, Jan 7, 5:41 PM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

76 lines

253 lines

ip_fw_table_value.c

112 lines

Diff 169256

sys/netpfil/ipfw/ip_fw_table.h

Loading...

sys/netpfil/ipfw/ip_fw_table.c

Loading...

sys/netpfil/ipfw/ip_fw_table_value.c

Loading...