Differential D54580

ipfw: remove locking workarounds in the table code
ClosedPublic
Actions

Authored by glebius on Jan 7 2026, 5:41 PM.

Tags

None

Referenced Files

	F151333781: D54580.id.diff
	Tue, Apr 7, 4:26 PM

	F151328092: D54580.id169256.diff
	Tue, Apr 7, 3:28 PM

	Unknown Object (File)
	Sun, Mar 15, 3:48 PM

	Unknown Object (File)
	Thu, Mar 12, 3:26 AM

	Unknown Object (File)
	Mon, Mar 9, 7:21 PM

	Unknown Object (File)
	Mar 6 2026, 10:59 AM

	Unknown Object (File)
	Mar 1 2026, 1:29 PM

	Unknown Object (File)
	Feb 11 2026, 1:39 AM

View All 20 Files

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

ae
melifaro
lytboris_gmail.com

Group Reviewers

Commits

rGb0c13e7e2446: ipfw: remove locking workarounds in the table code

Summary

Before the "upper half lock" became sleepable the table manipulation code
needed sophisticated workarounds to recover from races, where the lock is
temporarily dropped to do malloc(M_WAITOK). Remove all these workarounds
as they are no longer needed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Jan 7 2026, 5:41 PM

Herald added subscribers: vegeta_tuxpowered.net, donner, imp. · View Herald TranscriptJan 7 2026, 5:41 PM

glebius requested review of this revision.Jan 7 2026, 5:41 PM

glebius added a parent revision: D54535: ipfw: make the upper half lock sleepable.

Harbormaster completed remote builds in B69689: Diff 169256.Jan 7 2026, 5:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 17 2026, 12:46 AM

Closed by commit rGb0c13e7e2446: ipfw: remove locking workarounds in the table code (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGb0c13e7e2446: ipfw: remove locking workarounds in the table code.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

76 lines

253 lines

ip_fw_table_value.c

112 lines

Diff 169921

sys/netpfil/ipfw/ip_fw_table.h

Loading...

sys/netpfil/ipfw/ip_fw_table.c

Loading...

sys/netpfil/ipfw/ip_fw_table_value.c

Loading...