Page MenuHomeFreeBSD

acpi: Free ivars in bus_child_deleted method
ClosedPublic

Authored by jhb on Fri, Dec 19, 3:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 14, 4:40 AM
Unknown Object (File)
Mon, Jan 12, 4:10 PM
Unknown Object (File)
Mon, Jan 12, 4:10 PM
Unknown Object (File)
Mon, Jan 12, 3:47 PM
Unknown Object (File)
Sat, Jan 10, 4:50 AM
Unknown Object (File)
Sat, Jan 10, 4:42 AM
Unknown Object (File)
Fri, Jan 9, 7:07 PM
Unknown Object (File)
Wed, Jan 7, 10:31 PM
Subscribers
None

Details

Summary

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp added inline comments.
sys/dev/acpica/acpi.c
1119

This makes me wonder if there's some way we can detect leaks like this...
The change is, of course, spot on.

This revision is now accepted and ready to land.Fri, Dec 19, 4:15 PM
sys/dev/acpica/acpi.c
1119

Maybe MSAN? The thing is, ACPI devices are rarely deleted, so it would be hard to trigger a leak I think. I only noticed this by code reading.

This revision was automatically updated to reflect the committed changes.