Page MenuHomeFreeBSD
Differential D54309

acpi: Free ivars in bus_child_deleted method
AcceptedPublic
Actions

Authored by jhb on Fri, Dec 19, 3:25 PM.
Tags
None
Referenced Files
F140134193: D54309.id.diff
Sat, Dec 20, 5:05 PM
F140078138: D54309.id.diff
Fri, Dec 19, 10:55 PM
F140071724: D54309.diff
Fri, Dec 19, 8:53 PM
Unknown Object (File)
Fri, Dec 19, 7:31 PM
Unknown Object (File)
Fri, Dec 19, 7:00 PM
Subscribers
None

Details

Reviewers
imp
jkim
Summary

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69397
Build 66280: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Fri, Dec 19, 3:25 PM
jhb created this revision.
jhb added a parent revision: D54308: acpidump: Extend the decoding of entries in the EINJ and ERST tables.
jhb added a child revision: D54310: acpi_apei: Remove the hest member from the softc.
Harbormaster completed remote builds in B69397: Diff 168415.Fri, Dec 19, 3:26 PM
imp accepted this revision.Fri, Dec 19, 4:15 PM
imp added inline comments.
sys/dev/acpica/acpi.c
1119

This makes me wonder if there's some way we can detect leaks like this...
The change is, of course, spot on.

This revision is now accepted and ready to land.Fri, Dec 19, 4:15 PM
jhb added inline comments.Fri, Dec 19, 6:17 PM
sys/dev/acpica/acpi.c
1119

Maybe MSAN? The thing is, ACPI devices are rarely deleted, so it would be hard to trigger a leak I think. I only noticed this by code reading.

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
1 line

Diff 168415

View Options

sys/dev/acpica/acpi.c

Loading...