Page MenuHomeFreeBSD

acpi: Use M_WAITOK in acpi_register_ioctl
AcceptedPublic

Authored by jhb on Fri, Dec 19, 3:26 PM.
Tags
None
Referenced Files
F140063904: D54312.diff
Fri, Dec 19, 6:03 PM
F140063579: D54312.diff
Fri, Dec 19, 5:56 PM
F140063044: D54312.id.diff
Fri, Dec 19, 5:43 PM
F140062679: D54312.id168418.diff
Fri, Dec 19, 5:36 PM
F140062633: D54312.id.diff
Fri, Dec 19, 5:34 PM
Subscribers
None

Details

Reviewers
imp
jkim
Summary

This function is only called from device attach routines which can
sleep.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69400
Build 66283: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Fri, Dec 19, 4:16 PM

BTW, I've thought about adding an acpi_unregister_ioctl_all or the like that just takes the fn argument and unregisters all commands that use the same function. That would be a nicer way to handle unloading of a module that registers multiple handlers.