Differential D54174

sound: Do not check for NULL before free()
ClosedPublic
Actions

Authored by christos on Dec 11 2025, 11:17 AM.

Project Tags

None

Referenced Files

None

Subscribers

imp

Details

Reviewers

markj
emaste

Commits

rG4fc99fc60def: sound: Do not check for NULL before free()
rG792251295cdf: sound: Do not check for NULL before free()

Summary

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Dec 11 2025, 11:17 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 11 2025, 11:17 AM

christos requested review of this revision.Dec 11 2025, 11:17 AM

Harbormaster completed remote builds in B69176: Diff 167862.Dec 11 2025, 11:17 AM

markj added inline comments.Dec 11 2025, 2:07 PM

sys/dev/sound/pci/envy24.c
629	Presumably you still need to check this condition?
sys/dev/sound/pci/envy24ht.c
710	Same here.

Address Mark's comments.

Harbormaster completed remote builds in B69177: Diff 167864.Dec 11 2025, 2:11 PM

markj accepted this revision.Dec 11 2025, 2:17 PM

This revision is now accepted and ready to land.Dec 11 2025, 2:17 PM

Closed by commit rG792251295cdf: sound: Do not check for NULL before free(). · Explain WhyJan 2 2026, 4:59 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG792251295cdf: sound: Do not check for NULL before free().

christos added a commit: rG4fc99fc60def: sound: Do not check for NULL before free().Jan 9 2026, 11:28 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

dummy.c

3 lines

fdt/

audio_soc.c

6 lines

midi/

midi.c

6 lines

pci/

3 lines

6 lines

6 lines

3 lines

12 lines

12 lines

3 lines

2 lines

pcm/

19 lines

3 lines

3 lines

3 lines

3 lines

3 lines

37 lines

3 lines

usb/

uaudio.c

6 lines

Diff 168890

View Options

sys/dev/sound/dummy.c

View Options

sys/dev/sound/fdt/audio_soc.c

View Options

sys/dev/sound/midi/midi.c

View Options

sys/dev/sound/pci/cmi.c

View Options

sys/dev/sound/pci/envy24.c

View Options

sys/dev/sound/pci/envy24ht.c

View Options

sys/dev/sound/pci/es137x.c

View Options

sys/dev/sound/pci/hdsp-pcm.c

View Options

sys/dev/sound/pci/hdspe-pcm.c

View Options

sys/dev/sound/pci/via8233.c

View Options

sys/dev/sound/pci/via82c686.c

View Options

sys/dev/sound/pcm/buffer.c

View Options

sys/dev/sound/pcm/dsp.c

View Options

sys/dev/sound/pcm/feeder_eq.c

View Options

sys/dev/sound/pcm/feeder_format.c

View Options

sys/dev/sound/pcm/feeder_matrix.c

View Options

sys/dev/sound/pcm/feeder_mixer.c

View Options

sys/dev/sound/pcm/feeder_rate.c

View Options

sys/dev/sound/pcm/feeder_volume.c

View Options

sys/dev/sound/usb/uaudio.c

sound: Do not check for NULL before free()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 168890

sys/dev/sound/dummy.c

sys/dev/sound/fdt/audio_soc.c

sys/dev/sound/midi/midi.c

sys/dev/sound/pci/cmi.c

sys/dev/sound/pci/envy24.c

sys/dev/sound/pci/envy24ht.c

sys/dev/sound/pci/es137x.c

sys/dev/sound/pci/hdsp-pcm.c

sys/dev/sound/pci/hdspe-pcm.c

sys/dev/sound/pci/via8233.c

sys/dev/sound/pci/via82c686.c

sys/dev/sound/pcm/buffer.c

sys/dev/sound/pcm/dsp.c

sys/dev/sound/pcm/feeder_eq.c

sys/dev/sound/pcm/feeder_format.c

sys/dev/sound/pcm/feeder_matrix.c

sys/dev/sound/pcm/feeder_mixer.c

sys/dev/sound/pcm/feeder_rate.c

sys/dev/sound/pcm/feeder_volume.c

sys/dev/sound/usb/uaudio.c

sound: Do not check for NULL before free()
ClosedPublic
Actions

Revision Contents
Changeset List