Page MenuHomeFreeBSD
Differential D54103

sound: Retire pcm_feeder->desc_static
ClosedPublic
Actions

Authored by christos on Dec 6 2025, 3:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 8, 11:00 PM
Unknown Object (File)
Dec 30 2025, 12:29 PM
Unknown Object (File)
Dec 28 2025, 5:22 AM
Unknown Object (File)
Dec 20 2025, 2:15 AM
Unknown Object (File)
Dec 9 2025, 8:02 AM
Unknown Object (File)
Dec 9 2025, 7:58 AM
Unknown Object (File)
Dec 9 2025, 2:49 AM
Unknown Object (File)
Dec 9 2025, 1:43 AM
View All 10 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rG353a529d3a75: sound: Retire pcm_feeder->desc_static
rG84976625da38: sound: Retire pcm_feeder->desc_static
Summary

Not sure what the value of this was.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Dec 6 2025, 3:39 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 6 2025, 3:39 PM
christos requested review of this revision.Dec 6 2025, 3:39 PM
Harbormaster completed remote builds in B69101: Diff 167648.Dec 6 2025, 3:39 PM
markj accepted this revision.Dec 8 2025, 2:43 PM

Not sure what the value of this was.

Looking at commit b8a3639565c4a, my guess is that the author just didn't want to update all the code which references feeder->desc.

This revision is now accepted and ready to land.Dec 8 2025, 2:43 PM
Closed by commit rG84976625da38: sound: Retire pcm_feeder->desc_static (authored by christos). · Explain WhyJan 2 2026, 4:58 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG84976625da38: sound: Retire pcm_feeder->desc_static.
christos added a commit: rG353a529d3a75: sound: Retire pcm_feeder->desc_static.Fri, Jan 9, 11:27 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
2 lines
3 lines
4 lines
10 lines
14 lines
9 lines
10 lines
8 lines
14 lines
36 lines

Diff 168882

View Options

sys/dev/sound/pcm/feeder.h

Loading...
View Options

sys/dev/sound/pcm/feeder.c

Loading...
View Options

sys/dev/sound/pcm/feeder_chain.c

Loading...
View Options

sys/dev/sound/pcm/feeder_eq.c

Loading...
View Options

sys/dev/sound/pcm/feeder_format.c

Loading...
View Options

sys/dev/sound/pcm/feeder_matrix.c

Loading...
View Options

sys/dev/sound/pcm/feeder_mixer.c

Loading...
View Options

sys/dev/sound/pcm/feeder_rate.c

Loading...
View Options

sys/dev/sound/pcm/feeder_volume.c

Loading...
View Options

sys/dev/sound/pcm/sndstat.c

Loading...