ipfw: Check for errors from sooptcopyin() and sooptcopyout()
ClosedPublic
Actions

Authored by markj on Oct 13 2025, 1:25 PM.

Details

Reviewers

Commits

rGeaafcf841ce8: ipfw: Check for errors from sooptcopyin() and sooptcopyout()
rGc839eecec5e2: ipfw: Check for errors from sooptcopyin() and sooptcopyout()
rG6dfca589ea75: ipfw: Check for errors from sooptcopyin() and sooptcopyout()
rG302c4c540e44: ipfw: Check for errors from sooptcopyin() and sooptcopyout()
rG2df39ce5d4a8: ipfw: Check for errors from sooptcopyin() and sooptcopyout()

Summary

Note, it looks like this code may be unused since commit 4a77657cbc01
("ipfw: migrate ipfw to 32-bit size rule numbers"). In particular, it
looks like the ipfw_nat_*_ptr pointers are unused now.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 67751
Build 64634: arc lint + arc unit

Event Timeline

markj created this revision.Oct 13 2025, 1:25 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, donner and 2 others. · View Herald TranscriptOct 13 2025, 1:25 PM

markj requested review of this revision.Oct 13 2025, 1:25 PM

Harbormaster completed remote builds in B67751: Diff 164091.Oct 13 2025, 1:25 PM

Yes, I think they were replaced with handlers from ipfw_sopt_handler.

This revision is now accepted and ready to land.Oct 14 2025, 7:38 AM

In D53068#1212662, @ae wrote:

Yes, I think they were replaced with handlers from ipfw_sopt_handler.

Ok. I will commit anyway since the change needs to be MFCed. Will you clean up the old handlers?

Closed by commit rG2df39ce5d4a8: ipfw: Check for errors from sooptcopyin() and sooptcopyout() (authored by markj). · Explain WhyOct 14 2025, 1:51 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG2df39ce5d4a8: ipfw: Check for errors from sooptcopyin() and sooptcopyout().

markj added a commit: rG302c4c540e44: ipfw: Check for errors from sooptcopyin() and sooptcopyout().Oct 22 2025, 12:52 PM

markj added a commit: rG6dfca589ea75: ipfw: Check for errors from sooptcopyin() and sooptcopyout().Oct 22 2025, 1:01 PM

markj added a commit: rGc839eecec5e2: ipfw: Check for errors from sooptcopyin() and sooptcopyout().

cperciva added a commit: rGeaafcf841ce8: ipfw: Check for errors from sooptcopyin() and sooptcopyout().Oct 22 2025, 8:15 PM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

ip_fw_nat.c

12 lines

Diff 164091

View Options

sys/netpfil/ipfw/ip_fw_nat.c

ipfw: Check for errors from sooptcopyin() and sooptcopyout()ClosedPublicActions