Page MenuHomeFreeBSD
Differential D53068

ipfw: Check for errors from sooptcopyin() and sooptcopyout()
ClosedPublic
Actions

Authored by markj on Oct 13 2025, 1:25 PM.
Tags
None
Referenced Files
F172770007: D53068.diff
Sun, Sep 20, 9:08 PM
F172735492: D53068.id.diff
Sun, Sep 20, 3:34 PM
F172685826: D53068.diff
Sun, Sep 20, 5:29 AM
Unknown Object (File)
Fri, Sep 11, 1:57 AM
Unknown Object (File)
Tue, Sep 8, 10:32 AM
Unknown Object (File)
Tue, Sep 8, 12:25 AM
Unknown Object (File)
Fri, Sep 4, 4:48 AM
Unknown Object (File)
Thu, Sep 3, 5:26 AM
View All Files
Subscribers
donner
glebius
imp
melifaro
vegeta_tuxpowered.net

Details

Reviewers
ae
Commits
rGeaafcf841ce8: ipfw: Check for errors from sooptcopyin() and sooptcopyout()
rGc839eecec5e2: ipfw: Check for errors from sooptcopyin() and sooptcopyout()
rG6dfca589ea75: ipfw: Check for errors from sooptcopyin() and sooptcopyout()
rG302c4c540e44: ipfw: Check for errors from sooptcopyin() and sooptcopyout()
rG2df39ce5d4a8: ipfw: Check for errors from sooptcopyin() and sooptcopyout()
Summary

Note, it looks like this code may be unused since commit 4a77657cbc01
("ipfw: migrate ipfw to 32-bit size rule numbers"). In particular, it
looks like the ipfw_nat_*_ptr pointers are unused now.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Oct 13 2025, 1:25 PM
Herald added subscribers: vegeta_tuxpowered.net, glebius, donner and 2 others. · View Herald TranscriptOct 13 2025, 1:25 PM
markj requested review of this revision.Oct 13 2025, 1:25 PM
Harbormaster completed remote builds in B67751: Diff 164091.Oct 13 2025, 1:25 PM
ae accepted this revision.Oct 14 2025, 7:38 AM

Yes, I think they were replaced with handlers from ipfw_sopt_handler.

This revision is now accepted and ready to land.Oct 14 2025, 7:38 AM
markj added a comment.Oct 14 2025, 1:15 PM
In D53068#1212662, @ae wrote:

Yes, I think they were replaced with handlers from ipfw_sopt_handler.

Ok. I will commit anyway since the change needs to be MFCed. Will you clean up the old handlers?

Closed by commit rG2df39ce5d4a8: ipfw: Check for errors from sooptcopyin() and sooptcopyout() (authored by markj). · Explain WhyOct 14 2025, 1:51 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG2df39ce5d4a8: ipfw: Check for errors from sooptcopyin() and sooptcopyout().
markj added a commit: rG302c4c540e44: ipfw: Check for errors from sooptcopyin() and sooptcopyout().Oct 22 2025, 12:52 PM
markj added a commit: rG6dfca589ea75: ipfw: Check for errors from sooptcopyin() and sooptcopyout().Oct 22 2025, 1:01 PM
markj added a commit: rGc839eecec5e2: ipfw: Check for errors from sooptcopyin() and sooptcopyout().
cperciva added a commit: rGeaafcf841ce8: ipfw: Check for errors from sooptcopyin() and sooptcopyout().Oct 22 2025, 8:15 PM

Revision Contents
Changeset List

PathSize
sys/
netpfil/
ipfw/
12 lines

Diff 164142

View Options

sys/netpfil/ipfw/ip_fw_nat.c

Loading...