netstat: improve output
ClosedPublic
Actions

Authored by tuexen on Aug 28 2025, 8:53 PM.

Details

Reviewers

glebius
rscheff
cc
peter.lei_ieee.org
lstewart
nickbanks_netflix.com

Commits

rGa0627bc6923c: netstat: improve output for tcp stats

Summary

Use consistent indentation of SYN-cookie related counters, which belong to the SYN-cache container,

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Aug 28 2025, 8:53 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 28 2025, 8:53 PM

tuexen requested review of this revision.Aug 28 2025, 8:53 PM

I don't fully accept this change. Cookies & syncache are two different modules from sysadmin's view, although massively intertwined inside the implementation.

What about indenting only the three lower lines but keep cookies sent at the zero indentation, so it acts as a header? Just as syncache entries added acts as a header for the syncache module.

In D52227#1194591, @glebius wrote:

I don't fully accept this change. Cookies & syncache are two different modules from sysadmin's view, although massively intertwined inside the implementation.

What about indenting only the three lower lines but keep cookies sent at the zero indentation, so it acts as a header? Just as syncache entries added acts as a header for the syncache module.

That was my original change, but wasn't sure if it OK to create a new container. Will update the patch.

Use a container for SYN-cookie related counters as suggested by glebius@.

Haven't checked the actual output of the new version, but looks like the desired change.

This revision is now accepted and ready to land.Sep 1 2025, 10:14 PM

Closed by commit rGa0627bc6923c: netstat: improve output for tcp stats (authored by tuexen). · Explain WhySep 1 2025, 10:29 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGa0627bc6923c: netstat: improve output for tcp stats.