Differential D51739

libusb: implement libusb_wrap_sys_device
ClosedPublic
Actions

Authored by aokblast on Aug 5 2025, 1:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 20, 6:42 AM

	Unknown Object (File)
	Mon, May 11, 4:22 AM

	Unknown Object (File)
	Mon, May 11, 4:22 AM

	Unknown Object (File)
	Sat, May 9, 9:18 PM

	Unknown Object (File)
	Sat, May 9, 9:12 PM

	Unknown Object (File)
	Sat, May 9, 11:41 AM

	Unknown Object (File)
	Sat, May 9, 11:34 AM

	Unknown Object (File)
	Wed, May 6, 4:52 PM

View All 61 Files

Subscribers

Details

Reviewers

markj
lwhsu

Group Reviewers

Commits

rG872065688515: libusb: implement libusb_wrap_sys_device

Summary

The libusb_wrap_sys_device function can wrap an opened fd from the
system into a libusb handler. However, in FreeBSD's libusb implementation, a
USB device contains two fds: one for control transfers and another for
normal (bulk, interrupt, isochronous) transfers.

This design makes it impossible for FreeBSD to implement this function
without exposing a different structure in libusb.h to provide two fds.
Therefore, we return LIBUSB_ERROR_NOT_SUPPORTED to maintain API
compatibility.

Sponsored By: The FreeBSD Foundation.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aokblast created this revision.Aug 5 2025, 1:18 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptAug 5 2025, 1:18 PM

aokblast requested review of this revision.Aug 5 2025, 1:18 PM

Harbormaster completed remote builds in B65972: Diff 159765.Aug 5 2025, 1:18 PM

aokblast added reviewers: markj, lwhsu.Aug 5 2025, 1:21 PM

aokblast added a reviewer: manpages.

markj added inline comments.Aug 5 2025, 1:24 PM

lib/libusb/libusb.3
215
lib/libusb/libusb10.c
1922	Extra newline.

Fixes

Harbormaster completed remote builds in B65973: Diff 159766.Aug 5 2025, 1:32 PM

Approved

This revision is now accepted and ready to land.Aug 5 2025, 1:36 PM

lwhsu accepted this revision.Aug 6 2025, 4:36 AM

lwhsu added inline comments.

lib/libusb/libusb.3
213

Closed by commit rG872065688515: libusb: implement libusb_wrap_sys_device (authored by aokblast). · Explain WhyAug 6 2025, 2:20 PM

This revision was automatically updated to reflect the committed changes.

aokblast added a commit: rG872065688515: libusb: implement libusb_wrap_sys_device.

Revision Contents
Changeset List

Path

Size

lib/

libusb/

1 line

8 lines

7 lines

Diff 159865

lib/libusb/libusb.h

Loading...

lib/libusb/libusb.3

Loading...

lib/libusb/libusb10.c

Loading...