gone_in: make it __printflike()
ClosedPublic
Actions

Authored by glebius on Jun 10 2025, 7:59 PM.

Details

Reviewers

Commits

rG01addd846c64: gone_in: make it __printflike()

Summary

Provide flexibility to use format strings for gone_in(). As a side
effect, this removes hardcoded string "Obsolete code will be removed
soon:" from the message, so now it is obligation of the deprecated code to
provide a meaningful message. This required a small adoption of the
existing users: midi, drm2 and le(4). Note that gone_in() is not a public
KPI as it has no sense to use it outside of the FreeBSD tree.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Jun 10 2025, 7:59 PM

Herald added a subscriber: olce. · View Herald TranscriptJun 10 2025, 7:59 PM

glebius requested review of this revision.Jun 10 2025, 7:59 PM

Harbormaster completed remote builds in B64753: Diff 156800.Jun 10 2025, 7:59 PM

glebius added a child revision: D50784: gone_in: enforce printing only once.Jun 10 2025, 7:59 PM

imp accepted this revision.Jun 10 2025, 11:36 PM

imp added inline comments.

sys/dev/drm2/drm_os_freebsd.h
161	All this can just be deleted. We ONLY use this on arm these days.... And it's not deprecated there, eh? It will go away when armv7 goes away.
sys/dev/le/lance.c
197	maybe we should just delete this driver, since we've warned it for a while...
sys/dev/sound/midi/sequencer.c
523	I think this is going away.
743	Same, eh?

This revision is now accepted and ready to land.Jun 10 2025, 11:36 PM

I agree that we warned a lot on these two drivers and should remove it. Of course not as port of this revision. Can you please also look at D50784, that depends on this one?

Closed by commit rG01addd846c64: gone_in: make it __printflike() (authored by glebius). · Explain WhyTue, Jun 24, 10:25 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG01addd846c64: gone_in: make it __printflike().