Page MenuHomeFreeBSD

LinuxKPI: pci: fix two errors in lkpi_pci_get_device()
ClosedPublic

Authored by bz on May 4 2025, 10:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 7, 5:27 PM
Unknown Object (File)
Wed, Mar 4, 5:25 PM
Unknown Object (File)
Sun, Feb 22, 2:44 PM
Unknown Object (File)
Jan 30 2026, 9:20 PM
Unknown Object (File)
Jan 19 2026, 2:29 PM
Unknown Object (File)
Jan 16 2026, 8:20 PM
Unknown Object (File)
Jan 16 2026, 3:01 PM
Unknown Object (File)
Jan 16 2026, 1:21 AM
Subscribers

Details

Summary

On any result we need to acquire a reference. pci_dev_get() deals with
a NULL argument so we can simply pass what we "found" at the end.
This will avoid reference count problems.

If the iteration on the linux list in lkpi_pci_get_device() does
not find a match pdev will still be defined at the end of the
loop but not pointing to a valid pdev.
Store the found entry in a 2nd variable which otherwise will be NULL.
This will avoid random panics, usually in sysfs_remove_dir() when
the reference gets released.

Found during mt76 bringup.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Fixes: 8f61992d7cc11

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable