Page MenuHomeFreeBSD

LinuxKPI: pci: fix two errors in lkpi_pci_get_device()
ClosedPublic

Authored by bz on May 4 2025, 10:03 PM.
Tags
None
Referenced Files
F132313829: D50153.id154809.diff
Wed, Oct 15, 7:31 PM
Unknown Object (File)
Mon, Oct 6, 3:15 AM
Unknown Object (File)
Tue, Sep 30, 9:29 AM
Unknown Object (File)
Thu, Sep 25, 6:19 PM
Unknown Object (File)
Tue, Sep 16, 9:42 AM
Unknown Object (File)
Sep 8 2025, 2:41 PM
Unknown Object (File)
Aug 29 2025, 10:59 PM
Unknown Object (File)
Aug 28 2025, 10:12 AM
Subscribers

Details

Summary

On any result we need to acquire a reference. pci_dev_get() deals with
a NULL argument so we can simply pass what we "found" at the end.
This will avoid reference count problems.

If the iteration on the linux list in lkpi_pci_get_device() does
not find a match pdev will still be defined at the end of the
loop but not pointing to a valid pdev.
Store the found entry in a 2nd variable which otherwise will be NULL.
This will avoid random panics, usually in sysfs_remove_dir() when
the reference gets released.

Found during mt76 bringup.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Fixes: 8f61992d7cc11

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable