Differential D49274

new-bus: Use M_WAITOK in more places
ClosedPublic
Actions

Authored by jhb on Mar 6 2025, 10:07 PM.

Tags

None

Referenced Files

	F137999225: D49274.id152097.diff
	Fri, Nov 28, 12:51 AM

	F137955224: D49274.id.diff
	Thu, Nov 27, 4:12 PM

	Unknown Object (File)
	Wed, Nov 26, 6:46 AM

	Unknown Object (File)
	Mon, Nov 24, 7:31 AM

	Unknown Object (File)
	Thu, Nov 20, 3:28 PM

	Unknown Object (File)
	Thu, Nov 20, 1:37 PM

	Unknown Object (File)
	Thu, Nov 20, 1:35 PM

	Unknown Object (File)
	Thu, Nov 20, 1:28 PM

View All 55 Files

Subscribers

Details

Reviewers

Commits

rGb8b5cc330490: new-bus: Use M_WAITOK in more places

Summary

M_NOWAIT is now only used for devclass_get_devices,
devclass_get_drivers, and device_get_children. Other functions are
generally called from sleepable contexts such as module event
handlers, attach/detach routines, and the ioctl handler for
/dev/devctl2.

Suggested by: mjg (devclass_add_device)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Mar 6 2025, 10:07 PM

Herald added a subscriber: olce. · View Herald TranscriptMar 6 2025, 10:07 PM

jhb requested review of this revision.Mar 6 2025, 10:07 PM

jhb added a parent revision: D49273: devclass_alloc_unit: Go back to using M_WAITOK.

Harbormaster completed remote builds in B62810: Diff 151986.Mar 6 2025, 10:07 PM

This booted fine for me (no WITNESS warnings) in both a bhyve VM and my X1 Carbon.

sys/kern/subr_bus.c
2119	This didn't really handle failure

I think i chamged some of these in my tree. Now if i could jusr find that

This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2025, 5:36 PM

Closed by commit rGb8b5cc330490: new-bus: Use M_WAITOK in more places (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGb8b5cc330490: new-bus: Use M_WAITOK in more places.

Revision Contents
Changeset List

Path

Size

sys/

kern/

31 lines

Diff 152097

sys/kern/subr_bus.c

Loading...