newbus: Add more asserts that we hold the topo lock
AcceptedPublic
Actions

Authored by imp on Oct 29 2025, 6:08 PM.

Details

Reviewers

jhb
markj

Summary

Add more asserts that we hold the topo lock before callsing
devclass_find_internal. Also, take out the topo lock in the module
MOD_LOAD case for the root module.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68240
Build 65123: arc lint + arc unit

Event Timeline

imp created this revision.Oct 29 2025, 6:08 PM

Herald added a subscriber: olce. · View Herald TranscriptOct 29 2025, 6:08 PM

imp requested review of this revision.Oct 29 2025, 6:08 PM

Harbormaster completed remote builds in B68240: Diff 165349.Oct 29 2025, 6:08 PM

imp added a parent revision: D53451: newbus: Ensure that we hold topo lock for calls to devclass_find_internal.Oct 29 2025, 6:08 PM

imp added reviewers: jhb, markj.Oct 29 2025, 6:36 PM

markj added inline comments.Oct 29 2025, 7:37 PM

sys/kern/subr_bus.c
5241	You don't need the lock here too?

imp edited parent revisions, added: D53414: newbus: Take the topolock in driver_module_handler(); removed: D53451: newbus: Ensure that we hold topo lock for calls to devclass_find_internal.Mon, Nov 10, 10:15 PM

imp added inline comments.Mon, Nov 10, 10:22 PM

sys/kern/subr_bus.c
5241	Oh Yes. I thought this path was used on panic, but we turn off locking in that case, so I'll add this as a followup commit. https://reviews.freebsd.org/D53677