Paths

Table of Contentst

Differential D47733

sound: Remove dead code from pcm/
ClosedPublic
Actions

Authored by christos on Nov 25 2024, 2:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 14, 10:08 AM

	Unknown Object (File)
	Wed, Oct 14, 10:08 AM

	Unknown Object (File)
	Tue, Oct 6, 12:11 PM

	Unknown Object (File)
	Mon, Oct 5, 10:58 PM

	Unknown Object (File)
	Mon, Oct 5, 1:21 AM

	Unknown Object (File)
	Sun, Oct 4, 6:48 PM

	Unknown Object (File)
	Sun, Oct 4, 2:27 AM

	Unknown Object (File)
	Sat, Oct 3, 8:55 PM

Subscribers

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rG03241eb78078: sound: Remove dead code from pcm/
rG00731aaaed76: sound: Remove dead code from pcm/

Summary

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Nov 25 2024, 2:12 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 25 2024, 2:12 PM

christos requested review of this revision.Nov 25 2024, 2:12 PM

Harbormaster completed remote builds in B60755: Diff 146906.Nov 25 2024, 2:12 PM

I am open to discussion if it's worth keeping/using anything from this.

christos added inline comments.Nov 25 2024, 2:16 PM

sys/dev/sound/pcm/feeder_rate.c
1672	The comment here should also go if we remove the code below.

markj accepted this revision.Nov 25 2024, 8:26 PM

This revision is now accepted and ready to land.Nov 25 2024, 8:26 PM

I'm fine with the removal. Although it would be interesting to know more about some of the disabled code, it's probably not worth the effort to examine thoroughly.

sys/dev/sound/pcm/dsp.c
1259–1260	These comments don't make sense with `chn_wrupdate()` removed. Please grep, there's more occurrences.
1276–1277	Same here, this comment doesn't make sense with `chn_rdupdate()` removed.

emaste added inline comments.Nov 27 2024, 1:34 PM

sys/dev/sound/pcm/ac97.c
325	It looks like this was done because AC97_READ is sometimes inconsistent so we do it in a loop and ensure we get the same value twice. Maybe the `#if 0`'d code could be useful for debugging in the future, but if we want to keep it we could use something like `#ifdef DEBUG_INCONSISTENT_REGISTER_READS`

christos marked 2 inline comments as done.Nov 27 2024, 4:02 PM

christos added inline comments.

sys/dev/sound/pcm/ac97.c
325	We can keep it under `SND_DIAGNOSTIC`.

Closed by commit rG00731aaaed76: sound: Remove dead code from pcm/ (authored by christos). · Explain WhyDec 2 2024, 4:27 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG00731aaaed76: sound: Remove dead code from pcm/.

christos added a commit: rG03241eb78078: sound: Remove dead code from pcm/.Dec 4 2024, 12:04 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

23 lines

9 lines

53 lines

22 lines

26 lines

21 lines

Diff 147357

sys/dev/sound/pcm/ac97.c

Loading...

sys/dev/sound/pcm/buffer.c

Loading...

sys/dev/sound/pcm/channel.c

Loading...

sys/dev/sound/pcm/dsp.c

Loading...

sys/dev/sound/pcm/feeder.h

Loading...

sys/dev/sound/pcm/feeder_rate.c

Loading...