Page MenuHomeFreeBSD
Differential D47733

sound: Remove dead code from pcm/
ClosedPublic
Actions

Authored by christos on Nov 25 2024, 2:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 8, 11:11 PM
Unknown Object (File)
Fri, Nov 7, 10:54 PM
Unknown Object (File)
Fri, Oct 31, 12:23 PM
Unknown Object (File)
Oct 21 2025, 1:31 AM
Unknown Object (File)
Oct 19 2025, 9:13 AM
Unknown Object (File)
Oct 18 2025, 5:33 AM
Unknown Object (File)
Oct 4 2025, 6:40 AM
Unknown Object (File)
Sep 17 2025, 12:05 AM
View All 46 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rG03241eb78078: sound: Remove dead code from pcm/
rG00731aaaed76: sound: Remove dead code from pcm/
Summary

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Nov 25 2024, 2:12 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 25 2024, 2:12 PM
christos requested review of this revision.Nov 25 2024, 2:12 PM
Harbormaster completed remote builds in B60755: Diff 146906.Nov 25 2024, 2:12 PM
christos added a comment.EditedNov 25 2024, 2:13 PM

I am open to discussion if it's worth keeping/using anything from this.

christos added inline comments.Nov 25 2024, 2:16 PM
sys/dev/sound/pcm/feeder_rate.c
1672

The comment here should also go if we remove the code below.

markj accepted this revision.Nov 25 2024, 8:26 PM
This revision is now accepted and ready to land.Nov 25 2024, 8:26 PM
dev_submerge.ch accepted this revision.Nov 27 2024, 11:05 AM

I'm fine with the removal. Although it would be interesting to know more about some of the disabled code, it's probably not worth the effort to examine thoroughly.

sys/dev/sound/pcm/dsp.c
1259–1260

These comments don't make sense with chn_wrupdate() removed. Please grep, there's more occurrences.

1276–1277

Same here, this comment doesn't make sense with chn_rdupdate() removed.

emaste added inline comments.Nov 27 2024, 1:34 PM
sys/dev/sound/pcm/ac97.c
325

It looks like this was done because AC97_READ is sometimes inconsistent so we do it in a loop and ensure we get the same value twice. Maybe the #if 0'd code could be useful for debugging in the future, but if we want to keep it we could use something like #ifdef DEBUG_INCONSISTENT_REGISTER_READS

christos marked 2 inline comments as done.Nov 27 2024, 4:02 PM
christos added inline comments.
sys/dev/sound/pcm/ac97.c
325

We can keep it under SND_DIAGNOSTIC.

Closed by commit rG00731aaaed76: sound: Remove dead code from pcm/ (authored by christos). · Explain WhyDec 2 2024, 4:27 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG00731aaaed76: sound: Remove dead code from pcm/.
christos added a commit: rG03241eb78078: sound: Remove dead code from pcm/.Dec 4 2024, 12:04 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
23 lines
9 lines
53 lines
22 lines
26 lines
21 lines

Diff 147357

View Options

sys/dev/sound/pcm/ac97.c

Loading...
View Options

sys/dev/sound/pcm/buffer.c

Loading...
View Options

sys/dev/sound/pcm/channel.c

Loading...
View Options

sys/dev/sound/pcm/dsp.c

Loading...
View Options

sys/dev/sound/pcm/feeder.h

Loading...
View Options

sys/dev/sound/pcm/feeder_rate.c

Loading...