Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 60170 Build 57054: arc lint + arc unit
Event Timeline
libexec/rc/rc.subr | ||
---|---|---|
1799–1800 | We could probably drop this case as well (maybe in a seperate commit). People have had >20 years to notice the warning and update their systems. |
libexec/rc/rc.subr | ||
---|---|---|
1799–1800 | Yes |
libexec/rc/rc.subr | ||
---|---|---|
1799–1800 | Great idea! PR opened: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282290 |
Approved.
This probably deserves an entry in UPDATING as well as the relnotes tag, since it breaks backward compatibility and applies to those who track main as well as release users.
Approved, plus a minor nit.
share/man/man8/rc.subr.8 | ||
---|---|---|
1025–1026 | No need for the newline here. |
share/man/man8/rc.subr.8 | ||
---|---|---|
1025–1026 | Thanks for catching that. The whole sentence should read: However, it might also be ignored by .Ic run_rc_script if. |
I've got some reports from the NetBSD community that setting rc_fast_and_loose on NetBSD booting on vax simh makes rc finish in 109 seconds instead of 183 seconds (https://mastodon.sdf.org/@mrgtwentythree/113364676304360235).
At the same time, brooks@ mentioned in Bugzilla (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282255#c4) that the benefits of rc_fast_and_loose are probably negligible.
Well, Brooks' comment should probably be taken in the context of "on hardware where FreeBSD runs." With that, I suspect that that claim is still true.
Even if there is a marginal improvement (and there probably is on low-powered hardware or emulators), the option is not obviously worth the complexity, given that:
- it's broken (on FreeBSD), and not well-known
- fixing it would require a lot of time
- it introduces extra constraints for rc scripts, which are hard enough to write correctly already
I'd still vote for removing it.
I'm sure it adds appreciable speedup in some cases, but I can't see us fixing support and keeping it working. Best to stop pretending and focus on lower hanging fruit.