CONTRIBUTING: Explain Routes of Contributing

[ziaee]

Summary

Attempt to explain the 3 routes the project has for contribution.

This thread is not to debate which of these we want to use, this is to explain the current situation as accurately as possible to newcomers, and I am open to wording suggestions to more accurately describe the current situation. Having it undocumented because we want it to be different negatively impacts the project. Thanks!

Moved from my suggestion on https://github.com/freebsd/freebsd-ports/pull/250, which should be closed if this is acceptable.

If this is acceptable, please git commit --author ="Alexander Ziaee <[e-mail]>" so I can demonstrate my activity. Thanks!

[fernape]

LGTM

[mhorne]

Approved.

For this change you will want to tag it with:

Reviewed by: fernape
Approved by: fernape (ports)
Approved by: mhorne (mentor)

But I will withhold my 'Reviewed by' since it is outside of my area.

[jrm]

CONTRIBUTING.md

7

Optional rewording.

[pauamma_gundo.com]

Wording and spelling LGTM, with or without jrm's suggestion. I'm not a ports committer either, so I can't speak beyond that.

[diizzy]

Actually this is incorrect, they NEED to be submitted on bugzilla for timeouts etc to apply

[ziaee]

In D47169#1113528, @diizzy wrote:

Actually this is incorrect, they NEED to be submitted on bugzilla for timeouts etc to apply

That important information, thanks. I'm not sure how to integrate that with the wording. What are the other things in "etc"?

"Attachments to Bugzilla tickets are preferred, as this notifies existing maintainers. A bugzilla ticket is required for maintainer timeout."

?

[diizzy]

Submission to bugzilla is required for any policy defined my Porters Handbook to apply. I've asked this question before without getting any answer but do we have some kind of unified agreement that we're to accept PRs at all from GitHub from portmgr or people involved with ports?

[ziaee]

do we have some kind of unified agreement that we're to accept PRs at all from GitHub from portmgr or people involved with ports?

Ports are visible coming in every week via all three channels. As I mentioned in the revision description, I want to fix the issue of no longer accurate documentation in this file. The issue of ports comitters being unhappy about diversity of submission streams is outside my scope as a junior doc committer or the scope of this revision.

What I would like to do, is document it in the most accurate way possible that prevents as many problems as possible. I will make a new revision to note that policy based actions require a bugzilla ticket and tag you and all subscribers.

[imp]

In D47169#1114112, @diizzy wrote:

Submission to bugzilla is required for any policy defined my Porters Handbook to apply. I've asked this question before without getting any answer but do we have some kind of unified agreement that we're to accept PRs at all from GitHub from portmgr or people involved with ports?

We have what we always have in the FreeBSD project: sometimes PRs land via github. Nothing stronger has been officially promulgated at this time. There's no guarantee, but many things do land.

Until there's critical mass for this submission route, you aren't likely to see portmgr make any kind of statement given everything else on their plate. I could be wrong though.