arm64/gicv3: Skip programming vPE GITS_BASERs to avoid a boot crash.
ClosedPublic
Actions

Authored by scottph on Jul 24 2024, 1:15 AM.

Details

Reviewers

andrew
manu

Commits

rG21d9853ed553: arm64/gicv3: Skip programming vPE GITS_BASERs to avoid a boot crash

Summary

On AmpereOne, the current programming of GITS_BASER2 to individual
allocations per ITS causes a:

panic: APEI Fatal Hardware Error!

This is due to the ITS reporting a BASER2_DATA_ERR error. The GIC-700
expects all GITS_BASER2.Physical_Address fields to match system-wide.

Skip programming any vPE GITS_BASER registers to avoid this crash.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

scottph created this revision.Jul 24 2024, 1:15 AM

Herald added a reviewer: manu. · View Herald TranscriptJul 24 2024, 1:15 AM

Herald added subscribers: emaste, imp. · View Herald Transcript

scottph requested review of this revision.Jul 24 2024, 1:15 AM

scottph added inline comments.Jul 24 2024, 1:56 AM

sys/arm64/arm64/gicv3_its.c
597	s/ther/the/

bcran added a subscriber: bcran.Jul 24 2024, 2:09 AM

We don't use the vPE table so it's safe to ignore.

This revision is now accepted and ready to land.Jul 24 2024, 1:30 PM

Thanks Andrew, could you (or anybody else) help merge that? My commit bit is taking a nap at the moment.

@imp, @andrew, @jhb - I was wondering if one of you could commit this please?

Closed by commit rG21d9853ed553: arm64/gicv3: Skip programming vPE GITS_BASERs to avoid a boot crash (authored by scottph, committed by emaste). · Explain WhyOct 11 2024, 2:14 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG21d9853ed553: arm64/gicv3: Skip programming vPE GITS_BASERs to avoid a boot crash.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

gicv3_its.c

11 lines

Diff 141301

View Options

sys/arm64/arm64/gicv3_its.c

arm64/gicv3: Skip programming vPE GITS_BASERs to avoid a boot crash.ClosedPublicActions