iichid: Soften "Interrupt setup failed" message
ClosedPublic
Actions

Authored by emaste on Jul 23 2024, 5:41 PM.

Details

Reviewers

wulf
khorben_defora.org

Commits

rG35957d27eab4: iichid: Soften "Interrupt setup failed" message
rG0ac6cc3fd747: iichid: Soften "Interrupt setup failed" message

Summary

Users may interpret the message as a possible hardware error, but the
issue is in fact unimplemented functionality.  Reword the message to
avoid implying it is an error.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Jul 23 2024, 5:41 PM

emaste created this revision.

I don't have a full understanding to be certain, but "Unimplemented functionality" is based on reading comments in the src and commit message (b1f1b07f6d412cb3ec8588a634836e26396eec70: "interrupt resource acquisition is not always possible in a case of GPIO interrupts").

LGTM

This revision is now accepted and ready to land.Jul 23 2024, 8:32 PM

Closed by commit rG0ac6cc3fd747: iichid: Soften "Interrupt setup failed" message (authored by emaste). · Explain WhyJul 23 2024, 8:39 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG0ac6cc3fd747: iichid: Soften "Interrupt setup failed" message.

Herald added a subscriber: imp. · View Herald TranscriptJul 23 2024, 8:39 PM

emaste added a commit: rG35957d27eab4: iichid: Soften "Interrupt setup failed" message.Aug 1 2024, 4:11 PM