ifnet: Remove dead code
ClosedPublic
Actions

Authored by zlei on Jun 14 2024, 5:47 PM.

Tags

None

Referenced Files

	F165435427: D45599.id139855.diff
	Sat, Aug 8, 4:56 AM

	Unknown Object (File)
	Fri, Aug 7, 4:22 PM

	Unknown Object (File)
	Thu, Aug 6, 11:41 AM

	Unknown Object (File)
	Wed, Aug 5, 6:55 AM

	Unknown Object (File)
	Tue, Aug 4, 12:53 PM

	Unknown Object (File)
	Sun, Jul 26, 1:52 AM

	Unknown Object (File)
	Sat, Jul 25, 8:45 PM

	Unknown Object (File)
	Fri, Jul 24, 9:27 PM

Subscribers

Details

Reviewers

bz
kp

Group Reviewers

network

Commits

rG82c1ab4413e0: ifnet: Remove dead code
rGa8790965b0c6: ifnet: Remove dead code
rG9738277b5c66: ifnet: Remove dead code

Summary

Since change [1], if_bpf will not be detached by interface departure
eventhandler. Then the logic to re-attach if_bpf is dead and serve
no purpose any more.

This partially revert 05fc416403ec.

9ce40d321dd5 bpf: Fix incorrect cleanup

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Jun 14 2024, 5:47 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptJun 14 2024, 5:47 PM

zlei requested review of this revision.Jun 14 2024, 5:47 PM

kp accepted this revision as: kp.Jun 17 2024, 2:32 PM

This revision is now accepted and ready to land.Jun 17 2024, 2:32 PM

Closed by commit rG9738277b5c66: ifnet: Remove dead code (authored by zlei). · Explain WhyJun 30 2024, 9:46 AM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG9738277b5c66: ifnet: Remove dead code.

zlei added a commit: rGa8790965b0c6: ifnet: Remove dead code.Jul 8 2024, 11:33 AM

zlei added a commit: rG82c1ab4413e0: ifnet: Remove dead code.Jul 8 2024, 11:42 AM

Revision Contents
Changeset List

Path

Size

sys/

net/

if.c

18 lines

Diff 140370

View Options

ifnet: Remove dead codeClosedPublicActions