ifconfig: Fix default netmask calculation
ClosedPublic
Actions

Authored by grembo on Wed, Jun 12, 4:14 PM.

Details

Reviewers

bz
phk
emaste
kp

Commits

rG048ad7a9ef9f: ifconfig: Fix default netmask calculation
rG8a9f0fa42b1c: ifconfig: Fix default netmask calculation

Summary

In case an interface address without mask is set
(deprecated), use the correct bitmask (32 - nshift).

Test Plan

manual

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

grembo created this revision.Wed, Jun 12, 4:14 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Jun 12, 4:14 PM

grembo requested review of this revision.Wed, Jun 12, 4:14 PM

Harbormaster completed remote builds in B58157: Diff 139759.Wed, Jun 12, 4:14 PM

grembo added reviewers: bz, phk.Wed, Jun 12, 4:16 PM

There might be more correct ways to fix this, logically it should be sound.

Should be MFCed to 14.0 and 14.1 and maybe also deserves an EN.

emaste accepted this revision.Wed, Jun 12, 5:47 PM

This revision is now accepted and ready to land.Wed, Jun 12, 5:47 PM

kp accepted this revision.Wed, Jun 12, 5:57 PM

Closed by commit rG8a9f0fa42b1c: ifconfig: Fix default netmask calculation (authored by grembo). · Explain WhyWed, Jun 12, 6:12 PM

This revision was automatically updated to reflect the committed changes.

grembo added a commit: rG8a9f0fa42b1c: ifconfig: Fix default netmask calculation.

emaste mentioned this in D45585: ifconfig: turn interface address without mask into an error.Thu, Jun 13, 5:47 PM

grembo added a commit: rG048ad7a9ef9f: ifconfig: Fix default netmask calculation.Sat, Jun 15, 3:27 PM

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

af_inet.c

8 lines

Diff 139774

View Options

ifconfig: Fix default netmask calculationClosedPublicActions