arm64/rockchip: Fix the build with GCC
ClosedPublic
Actions

Authored by andrew on May 20 2024, 12:00 PM.

Details

Reviewers

brooks
imp
emaste
jhb
manu

Group Reviewers

arm64

Commits

rG4f012d7a7a47: arm64/rockchip: Fix the build with GCC

Summary

We were missing brackets in GPIO_FLAGS_PINCTRL. Without them GCC
complains a use is ambiguous. Fix by adding the needed brackets.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57778
Build 54666: arc lint + arc unit

Event Timeline

andrew created this revision.May 20 2024, 12:00 PM

Herald added a reviewer: manu. · View Herald TranscriptMay 20 2024, 12:00 PM

Herald added a subscriber: loos. · View Herald Transcript

andrew requested review of this revision.May 20 2024, 12:00 PM

andrew added a parent revision: D45263: arm64: Use the pointer auth register defines.

andrew added a child revision: D45265: pci: Fix pci_host_generic_acpi with gcc.

Harbormaster completed remote builds in B57778: Diff 138765.May 20 2024, 12:01 PM

manu accepted this revision.May 20 2024, 4:19 PM

This revision is now accepted and ready to land.May 20 2024, 4:19 PM

jhb accepted this revision.May 20 2024, 5:29 PM

emaste accepted this revision.May 20 2024, 5:34 PM

brooks accepted this revision.May 20 2024, 6:22 PM

imp accepted this revision.May 20 2024, 10:58 PM

Closed by commit rG4f012d7a7a47: arm64/rockchip: Fix the build with GCC (authored by andrew). · Explain WhyMay 22 2024, 8:34 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG4f012d7a7a47: arm64/rockchip: Fix the build with GCC.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

rockchip/

rk_gpio.c

2 lines

Diff 138765

View Options

sys/arm64/rockchip/rk_gpio.c

arm64/rockchip: Fix the build with GCCClosedPublicActions