arm64_pmap: narrow scope of bti_same test
ClosedPublic
Actions

Authored by dougm on Sat, May 11, 6:57 AM.

Details

Reviewers

alc
andrew
manu

Commits

rGb5a1f0406b9d: arm64_pmap: narrow scope of bti_same test

Summary

The pmap_bti_same test in pmap_enter_l3c only happens in the !ADDR_IS_KERNEL case; in the other case, a KASSERT fails. So move the test into that case to save a bit of time when ADDR_IS_KERNEL.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm created this revision.Sat, May 11, 6:57 AM

Herald added a reviewer: andrew. · View Herald TranscriptSat, May 11, 6:57 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added a subscriber: emaste. · View Herald Transcript

dougm requested review of this revision.Sat, May 11, 6:57 AM

andrew added inline comments.Mon, May 13, 4:20 PM

sys/arm64/arm64/pmap.c
5680–5681	This is unneeded, it always returns true for a kernel address as bti is always enabled.

Remove unneeded KASSERT.

dougm marked an inline comment as done.Mon, May 13, 5:41 PM

andrew accepted this revision.Mon, May 13, 6:05 PM

This revision is now accepted and ready to land.Mon, May 13, 6:05 PM

Closed by commit rGb5a1f0406b9d: arm64_pmap: narrow scope of bti_same test (authored by dougm). · Explain WhyTue, May 14, 4:24 AM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rGb5a1f0406b9d: arm64_pmap: narrow scope of bti_same test.

Herald added a subscriber: imp. · View Herald TranscriptTue, May 14, 4:24 AM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

pmap.c

27 lines

Diff 138517

View Options

arm64_pmap: narrow scope of bti_same testClosedPublicActions