Differential D44365

pf: avoid passing through dummynet multiple times
ClosedPublic
Actions

Authored by kp on Mar 15 2024, 2:11 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Feb 14, 5:44 PM

	Unknown Object (File)
	Tue, Feb 4, 8:47 PM

	Unknown Object (File)
	Tue, Feb 4, 8:38 PM

	Unknown Object (File)
	Tue, Feb 4, 8:36 PM

	Unknown Object (File)
	Tue, Feb 4, 8:36 PM

	Unknown Object (File)
	Tue, Feb 4, 8:31 PM

	Unknown Object (File)
	Tue, Feb 4, 8:28 PM

	Unknown Object (File)
	Mon, Jan 27, 8:22 AM

View All 61 Files

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG0ea0c026557b: pf: avoid passing through dummynet multiple times

Summary

In some setups we end up with multiple states created for a single
packet, which in turn can mean we run the packet through dummynet
multiple times. That's not expected or intended. Mark each packet when
it goes through dummynet, and do not pass packet through dummynet if
they're marked as having already passed through.

See also: https://redmine.pfsense.org/issues/14854
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56615
Build 53503: arc lint + arc unit

Event Timeline

kp created this revision.Mar 15 2024, 2:11 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptMar 15 2024, 2:11 AM

kp requested review of this revision.Mar 15 2024, 2:11 AM

kp added a child revision: D44366: pf: fix dummynet + route-to.

Harbormaster completed remote builds in B56615: Diff 135769.Mar 15 2024, 2:12 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 19 2024, 3:30 PM

Closed by commit rG0ea0c026557b: pf: avoid passing through dummynet multiple times (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG0ea0c026557b: pf: avoid passing through dummynet multiple times.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

4 lines

2 lines

tests/

sys/

netpfil/

pf/

53 lines

Diff 135769

sys/netpfil/pf/pf.c

Loading...

sys/netpfil/pf/pf_mtag.h

Loading...

tests/sys/netpfil/pf/route_to.sh

Loading...