ddb: Use bool for boolean variables in MD code

[markj]

sys/amd64/amd64/db_disasm.c

1046

short_addr should also be a bool.

1510

1512

1521

sys/i386/i386/db_disasm.c

939

1226

[jhb]

Nice catches

sys/amd64/amd64/db_disasm.c

  *     permissions:    755
  *     nlink:  58283552
  *     uid:    1001
  */
 
 #define DIR_METATABLE "directory iterator metatable"
 
 static int
+lua_dir_iter_pushtype(lua_State *L __unused, const struct dirent *ent __unused)
+{
+
+        /*
+         * This is a non-standard extension to luafilesystem for loader's
+         * benefit.  The extra stat() calls to determine the entry type can
+         * be quite expensive on some systems, so this speeds up enumeration of
+         * /boot greatly by providing the type up front.
+         *
+         * This extension is compatible enough with luafilesystem, in that we're
+         * just using an extra return value for the iterator.
+         */
+#ifdef _STANDALONE
+        lua_pushinteger(L, ent->d_type);
+        return 1;
+#else
+        return 0;
+#endif
+}
+
+static int
 lua_dir_iter_next(lua_State *L)
 {
         struct dirent *entry;
         DIR *dp, **dpp;
 
         dpp = (DIR **)luaL_checkudata(L, 1, DIR_METATABLE);
         dp = *dpp;
         luaL_argcheck(L, dp != NULL, 1, "closed directory");
 
 #ifdef _STANDALONE
         entry = readdirfd(dp->fd);
 #else
         entry = readdir(dp);
 #endif
         if (entry == NULL) {
                 closedir(dp);
                 *dpp = NULL;
                 return 0;
         }
 
         lua_pushstring(L, entry->d_name);
-        return 1;
+        return 1 + lua_dir_iter_pushtype(L, entry);
 }
 
 static int
 lua_dir_iter_close(lua_State *L)
 {
         DIR *dp, **dpp;
 
         dpp = (DIR **)lua_touserdata(L, 1);

 };
 #undef REG_SIMPLE
 
 int
 luaopen_lfs(lua_State *L)
 {
         register_metatable(L);
         luaL_newlib(L, fslib);
+#ifdef _STANDALONE
+        /* Non-standard extension for loader, used with lfs.dir(). */
+        lua_pushinteger(L, DT_DIR);
+        lua_setfield(L, -2, "DT_DIR");
+#endif
         return 1;
 }

sys/amd64/amd64/db_trace.c

  *     permissions:    755
  *     nlink:  58283552
  *     uid:    1001
  */
 
 #define DIR_METATABLE "directory iterator metatable"
 
 static int
+lua_dir_iter_pushtype(lua_State *L __unused, const struct dirent *ent __unused)
+{
+
+        /*
+         * This is a non-standard extension to luafilesystem for loader's
+         * benefit.  The extra stat() calls to determine the entry type can
+         * be quite expensive on some systems, so this speeds up enumeration of
+         * /boot greatly by providing the type up front.
+         *
+         * This extension is compatible enough with luafilesystem, in that we're
+         * just using an extra return value for the iterator.
+         */
+#ifdef _STANDALONE
+        lua_pushinteger(L, ent->d_type);
+        return 1;
+#else
+        return 0;
+#endif
+}
+
+static int
 lua_dir_iter_next(lua_State *L)
 {
         struct dirent *entry;
         DIR *dp, **dpp;
 
         dpp = (DIR **)luaL_checkudata(L, 1, DIR_METATABLE);
         dp = *dpp;
         luaL_argcheck(L, dp != NULL, 1, "closed directory");
 
 #ifdef _STANDALONE
         entry = readdirfd(dp->fd);
 #else
         entry = readdir(dp);
 #endif
         if (entry == NULL) {
                 closedir(dp);
                 *dpp = NULL;
                 return 0;
         }
 
         lua_pushstring(L, entry->d_name);
-        return 1;
+        return 1 + lua_dir_iter_pushtype(L, entry);
 }
 
 static int
 lua_dir_iter_close(lua_State *L)
 {
         DIR *dp, **dpp;
 
         dpp = (DIR **)lua_touserdata(L, 1);

 };
 #undef REG_SIMPLE
 
 int
 luaopen_lfs(lua_State *L)
 {
         register_metatable(L);
         luaL_newlib(L, fslib);
+#ifdef _STANDALONE
+        /* Non-standard extension for loader, used with lfs.dir(). */
+        lua_pushinteger(L, DT_DIR);
+        lua_setfield(L, -2, "DT_DIR");
+#endif
         return 1;
 }

sys/i386/i386/db_disasm.c

  *     permissions:    755
  *     nlink:  58283552
  *     uid:    1001
  */
 
 #define DIR_METATABLE "directory iterator metatable"
 
 static int
+lua_dir_iter_pushtype(lua_State *L __unused, const struct dirent *ent __unused)
+{
+
+        /*
+         * This is a non-standard extension to luafilesystem for loader's
+         * benefit.  The extra stat() calls to determine the entry type can
+         * be quite expensive on some systems, so this speeds up enumeration of
+         * /boot greatly by providing the type up front.
+         *
+         * This extension is compatible enough with luafilesystem, in that we're
+         * just using an extra return value for the iterator.
+         */
+#ifdef _STANDALONE
+        lua_pushinteger(L, ent->d_type);
+        return 1;
+#else
+        return 0;
+#endif
+}
+
+static int
 lua_dir_iter_next(lua_State *L)
 {
         struct dirent *entry;
         DIR *dp, **dpp;
 
         dpp = (DIR **)luaL_checkudata(L, 1, DIR_METATABLE);
         dp = *dpp;
         luaL_argcheck(L, dp != NULL, 1, "closed directory");
 
 #ifdef _STANDALONE
         entry = readdirfd(dp->fd);
 #else
         entry = readdir(dp);
 #endif
         if (entry == NULL) {
                 closedir(dp);
                 *dpp = NULL;
                 return 0;
         }
 
         lua_pushstring(L, entry->d_name);
-        return 1;
+        return 1 + lua_dir_iter_pushtype(L, entry);
 }
 
 static int
 lua_dir_iter_close(lua_State *L)
 {
         DIR *dp, **dpp;
 
         dpp = (DIR **)lua_touserdata(L, 1);

 };
 #undef REG_SIMPLE
 
 int
 luaopen_lfs(lua_State *L)
 {
         register_metatable(L);
         luaL_newlib(L, fslib);
+#ifdef _STANDALONE
+        /* Non-standard extension for loader, used with lfs.dir(). */
+        lua_pushinteger(L, DT_DIR);
+        lua_setfield(L, -2, "DT_DIR");
+#endif
         return 1;
 }

sys/powerpc/powerpc/db_trace.c

  *     permissions:    755
  *     nlink:  58283552
  *     uid:    1001
  */
 
 #define DIR_METATABLE "directory iterator metatable"
 
 static int
+lua_dir_iter_pushtype(lua_State *L __unused, const struct dirent *ent __unused)
+{
+
+        /*
+         * This is a non-standard extension to luafilesystem for loader's
+         * benefit.  The extra stat() calls to determine the entry type can
+         * be quite expensive on some systems, so this speeds up enumeration of
+         * /boot greatly by providing the type up front.
+         *
+         * This extension is compatible enough with luafilesystem, in that we're
+         * just using an extra return value for the iterator.
+         */
+#ifdef _STANDALONE
+        lua_pushinteger(L, ent->d_type);
+        return 1;
+#else
+        return 0;
+#endif
+}
+
+static int
 lua_dir_iter_next(lua_State *L)
 {
         struct dirent *entry;
         DIR *dp, **dpp;
 
         dpp = (DIR **)luaL_checkudata(L, 1, DIR_METATABLE);
         dp = *dpp;
         luaL_argcheck(L, dp != NULL, 1, "closed directory");
 
 #ifdef _STANDALONE
         entry = readdirfd(dp->fd);
 #else
         entry = readdir(dp);
 #endif
         if (entry == NULL) {
                 closedir(dp);
                 *dpp = NULL;
                 return 0;
         }
 
         lua_pushstring(L, entry->d_name);
-        return 1;
+        return 1 + lua_dir_iter_pushtype(L, entry);
 }
 
 static int
 lua_dir_iter_close(lua_State *L)
 {
         DIR *dp, **dpp;
 
         dpp = (DIR **)lua_touserdata(L, 1);

 };
 #undef REG_SIMPLE
 
 int
 luaopen_lfs(lua_State *L)
 {
         register_metatable(L);
         luaL_newlib(L, fslib);
+#ifdef _STANDALONE
+        /* Non-standard extension for loader, used with lfs.dir(). */
+        lua_pushinteger(L, DT_DIR);
+        lua_setfield(L, -2, "DT_DIR");
+#endif
         return 1;
 }