Page MenuHomeFreeBSD
Differential D41660

libc: add LIBC_MALLOC option
ClosedPublic
Actions

Authored by brooks on Aug 30 2023, 9:57 PM.
Tags
None
Referenced Files
F86590369: D41660.id.diff
Sat, Jun 22, 5:01 PM
Unknown Object (File)
Fri, Jun 21, 8:22 PM
Unknown Object (File)
Fri, Jun 21, 11:50 AM
Unknown Object (File)
Fri, Jun 21, 11:45 AM
Unknown Object (File)
Fri, Jun 21, 11:35 AM
Unknown Object (File)
Thu, Jun 13, 12:38 AM
Unknown Object (File)
May 5 2024, 3:04 AM
Unknown Object (File)
May 5 2024, 2:58 AM
View All 27 Files
Subscribers
bdrewery
emaste

Details

Reviewers
jrtc27
imp
jhb
emaste
Commits
rG09e32b2fddf5: libc: add LIBC_MALLOC option
Summary

This will enable alternative mallocs to be included in the tree and
selected by setting LIBC_MALLOC. As there is only one today (jemalloc)
this option does nothing, but will reduce diffs to CheriBSD.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Aug 30 2023, 9:57 PM
Herald added subscribers: emaste, bdrewery. · View Herald TranscriptAug 30 2023, 9:57 PM
brooks requested review of this revision.Aug 30 2023, 9:57 PM
brooks added a parent revision: D41659: share/mk: basic support for group options.
brooks updated this revision to Diff 126700.Aug 30 2023, 10:31 PM

Fix typo

Harbormaster completed remote builds in B53354: Diff 126697.Aug 31 2023, 3:32 AM
Harbormaster completed remote builds in B53357: Diff 126700.
brooks updated this revision to Diff 126745.Aug 31 2023, 7:27 PM

Add tools/build/options/LIBC_MALLOC

Harbormaster completed remote builds in B53377: Diff 126745.Aug 31 2023, 7:27 PM
brooks updated this revision to Diff 126754.Aug 31 2023, 10:03 PM

Remove .It from description

Harbormaster completed remote builds in B53384: Diff 126754.Aug 31 2023, 10:03 PM
emaste added a comment.Aug 31 2023, 11:10 PM

Not just reduce diffs with CheriBSD, we want to support alternate mallocs in FreeBSD

emaste accepted this revision.Aug 31 2023, 11:12 PM
emaste added inline comments.
tools/build/options/LIBC_MALLOC
10

Maybe add a note about other options being introduced in the future? Else it seems odd that we have an option that can only take one value.

This revision is now accepted and ready to land.Aug 31 2023, 11:12 PM
brooks updated this revision to Diff 126762.Aug 31 2023, 11:55 PM

Add note about future plans

This revision now requires review to proceed.Aug 31 2023, 11:55 PM
Harbormaster completed remote builds in B53391: Diff 126762.Aug 31 2023, 11:55 PM
emaste accepted this revision.Sep 1 2023, 12:09 AM
This revision is now accepted and ready to land.Sep 1 2023, 12:09 AM
brooks updated this revision to Diff 126765.Sep 1 2023, 12:29 AM

Define default value

This revision now requires review to proceed.Sep 1 2023, 12:29 AM
Harbormaster completed remote builds in B53393: Diff 126765.Sep 1 2023, 12:29 AM
emaste accepted this revision.Sep 1 2023, 12:58 AM
This revision is now accepted and ready to land.Sep 1 2023, 12:58 AM
Closed by commit rG09e32b2fddf5: libc: add LIBC_MALLOC option (authored by brooks). · Explain WhySep 1 2023, 4:55 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG09e32b2fddf5: libc: add LIBC_MALLOC option.

Revision Contents
Changeset List

PathSize
lib/
libc/
stdlib/
malloc/
2 lines
share/
mk/
6 lines
tools/
build/
options/
13 lines

Diff 126796

View Options

lib/libc/stdlib/malloc/Makefile.inc

Loading...
View Options

share/mk/src.opts.mk

Loading...
View Options

tools/build/options/LIBC_MALLOC

Loading...