nvme: Directly lookup op code
ClosedPublic
Actions

Authored by imp on Aug 7 2023, 10:12 PM.

Details

Reviewers

jhb
chuck
mav

Commits

rG2ad9a815fd58: nvme: Directly lookup op code

Summary

Rather than have a table to walk through, use a sparse array.

Suggested by: jhb
Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Aug 7 2023, 10:12 PM

Herald added a subscriber: dab. · View Herald TranscriptAug 7 2023, 10:12 PM

imp requested review of this revision.Aug 7 2023, 10:12 PM

Harbormaster completed remote builds in B53008: Diff 125673.Aug 7 2023, 10:12 PM

imp mentioned this in D41310: nvme: Eliminate redundant code.Aug 7 2023, 10:13 PM

imp added a parent revision: D41311: nvme: Add more NVME Base Spec 2.0 and NVME Command Set Spec 1.0a.

imp added a child revision: D41312: nvme: Convert adjacent bools to a bitfield.

jhb accepted this revision.Aug 7 2023, 10:45 PM

jhb added inline comments.

sys/dev/nvme/nvme_qpair.c
105	I do think you can change the `opc` type to uint8_t and then you can remove the check against DEFAULT_INDEX.

This revision is now accepted and ready to land.Aug 7 2023, 10:45 PM

Closed by commit rG2ad9a815fd58: nvme: Directly lookup op code (authored by imp). · Explain WhyAug 7 2023, 10:47 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG2ad9a815fd58: nvme: Directly lookup op code.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

nvme_qpair.c

114 lines

Diff 125682

View Options

nvme: Directly lookup op codeClosedPublicActions