Page MenuHomeFreeBSD
Differential D40704

tcp_lro: remove backup for non-inlined flsll
ClosedPublic
Actions

Authored by dougm on Jun 21 2023, 6:00 PM.
Tags
None
Referenced Files
F153550002: D40704.id123627.diff
Tue, Apr 21, 8:15 PM
Unknown Object (File)
Mon, Apr 20, 6:10 PM
Unknown Object (File)
Mon, Apr 20, 2:31 PM
Unknown Object (File)
Fri, Apr 17, 11:22 AM
Unknown Object (File)
Wed, Apr 15, 1:54 AM
Unknown Object (File)
Tue, Apr 14, 5:13 AM
Unknown Object (File)
Fri, Apr 10, 9:56 PM
Unknown Object (File)
Thu, Apr 2, 6:29 PM
View All Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
mhorne
tuexen
Group Reviewers
transport
Commits
rG8579bf27d7d3: inline_fls - HAVE_INLINE_FLSLL is always true
Summary

After D40698 is committed, flsll will be inlined, or replaced by a smart binary search implementation, on all architectures, and HAVE_INLINE_FLSLL will be #defined always. So remove code the the #undefined case.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm created this revision.Jun 21 2023, 6:00 PM
Herald added a reviewer: transport. · View Herald TranscriptJun 21 2023, 6:00 PM
Herald added subscribers: glebius, melifaro. · View Herald Transcript
dougm requested review of this revision.Jun 21 2023, 6:00 PM
mhorne accepted this revision.Jun 22 2023, 7:45 PM
dougm added a comment.Jul 6 2023, 6:43 PM

Why is this blocked by 'transport'?

dougm removed a reviewer: • hselasky.Jul 6 2023, 6:44 PM
mhorne added a comment.Jul 6 2023, 6:51 PM
In D40704#930792, @dougm wrote:

Why is this blocked by 'transport'?

It is some configured phabricator rule that applies to this file. Let this be a ping to any interested transport members.

@dougm if you do not hear within a day or two I do not think there is a problem with committing anyway.

tuexen accepted this revision.Jul 6 2023, 7:42 PM
This revision is now accepted and ready to land.Jul 6 2023, 7:42 PM
Closed by commit rG8579bf27d7d3: inline_fls - HAVE_INLINE_FLSLL is always true (authored by dougm). · Explain WhyJul 6 2023, 8:31 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rG8579bf27d7d3: inline_fls - HAVE_INLINE_FLSLL is always true.
Herald added a subscriber: imp. · View Herald TranscriptJul 6 2023, 8:31 PM
mhorne mentioned this in D54967: libkern: Add libcalls for ffs and __ffsdi2.Jan 30 2026, 5:58 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
14 lines

Diff 124249

View Options

sys/netinet/tcp_lro.c

Loading...