Page MenuHomeFreeBSD
Differential D40689

login.conf(5): Document priority's default and possible values
ClosedPublic
Actions

Authored by olce on Jun 21 2023, 1:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 13, 1:14 PM
Unknown Object (File)
Mon, May 13, 1:14 PM
Unknown Object (File)
Mon, May 13, 1:14 PM
Unknown Object (File)
Mon, May 13, 1:13 PM
Unknown Object (File)
Mon, May 13, 1:07 PM
Unknown Object (File)
Mon, May 13, 12:55 PM
Unknown Object (File)
Sun, May 12, 3:34 PM
Unknown Object (File)
Sun, May 12, 3:33 PM
View All 43 Files
Subscribers
andrew_tao173.riddles.org.uk
emaste
imp

Details

Reviewers
yuripv
kevans
mjg
des
kib
emaste
Commits
rGe7b89962dc6d: login.conf(5): Document priority's default and possible values
rG72d463479fcc: login.conf(5): Document priority's default and possible values
rGaa96945e71b0: login.conf(5): Document priority's default and possible values
Summary

Priority is reset to 0 if not explicitly specified.

While here, document that it is possible to set real-time or idle class'
priorities with this capability.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55688
Build 52577: arc lint + arc unit

Event Timeline

olce created this revision.Jun 21 2023, 1:50 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 21 2023, 1:50 PM
olce requested review of this revision.Jun 21 2023, 1:50 PM
Herald added a subscriber: andrew_tao173.riddles.org.uk. · View Herald TranscriptJun 21 2023, 1:50 PM
Harbormaster completed remote builds in B52223: Diff 123600.Jun 21 2023, 1:50 PM
olce added a parent revision: D40349: setusercontext(): Better error messages when priority is not set correctly.Jun 21 2023, 1:50 PM
olce added a child revision: D40350: setusercontext(): Move priority setting in new setclasspriority().Jun 21 2023, 1:53 PM
olce added reviewers: yuripv, kevans, mjg, des, kib.Jun 22 2023, 1:32 PM
olce updated this revision to Diff 123975.Jun 29 2023, 11:42 AM

Make new sentences start at new line.

Harbormaster completed remote builds in B52330: Diff 123975.Jun 29 2023, 11:42 AM
olce updated this revision to Diff 124742.Jul 16 2023, 4:30 PM

Be more explicit on what the "nice range" is.

Harbormaster completed remote builds in B52666: Diff 124742.Jul 16 2023, 4:30 PM
olce mentioned this in D40691: login.conf(5): Document priority's special value 'inherit'.Jul 16 2023, 4:32 PM
emaste added a subscriber: emaste.Jan 29 2024, 1:50 PM

The description still isn't completely clear to me. IIUC the values are:

-52 through -21 rtprio
-20 through 20 nice
21 through 52 idle

I'm not sure how much we want to say about this / how best to express this in login.conf(5) though.

olce updated this revision to Diff 133506.Jan 29 2024, 4:50 PM

Be even more explicit about the possible values for the property capability that map to the real-time or idle classes.

Harbormaster completed remote builds in B55688: Diff 133506.Jan 29 2024, 4:50 PM
emaste accepted this revision.Jan 29 2024, 7:46 PM

OK, this is fine for now.

This revision is now accepted and ready to land.Jan 29 2024, 7:46 PM
Closed by commit rGaa96945e71b0: login.conf(5): Document priority's default and possible values (authored by olce). · Explain WhyJan 29 2024, 10:32 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rGaa96945e71b0: login.conf(5): Document priority's default and possible values.
olce added a commit: rG72d463479fcc: login.conf(5): Document priority's default and possible values.Feb 1 2024, 9:26 PM
olce added a commit: rGe7b89962dc6d: login.conf(5): Document priority's default and possible values.Feb 1 2024, 9:32 PM

Revision Contents
Changeset List

PathSize
lib/
libutil/
16 lines

Diff 133506

View Options

lib/libutil/login.conf.5

Loading...