Paths

Table of Contentst

Fix TCP MD5 support for the BBR and RACK stack
ClosedPublic
Actions

Authored by tuexen on Jun 18 2023, 2:07 PM.

Details

Reviewers

rrs
glebius
rscheff
cc

Group Reviewers

transport

Commits

rGedff1d344c6b: tcp: fix TCP MD5 computation for the BBR and RACK stack
rG02b885b09d1e: tcp: fix TCP MD5 computation for the BBR and RACK stack

Summary

This patch ensures that the TCP MD5 digest is computed and copied correctly in the packet.

Test Plan

Run the corresponding packetdrill tests from the setsockopt group.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.Jun 18 2023, 2:07 PM

Herald added a reviewer: transport. · View Herald TranscriptJun 18 2023, 2:07 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Jun 18 2023, 2:07 PM

emaste added a subscriber: emaste.Jun 18 2023, 5:20 PM

lgtm

This revision is now accepted and ready to land.Jun 19 2023, 8:36 AM

cc accepted this revision.Jun 19 2023, 1:06 PM

bz added a subscriber: bz.Jun 19 2023, 9:22 PM

bz added inline comments.

sys/netinet/tcp_stacks/rack.c
18923	Indentation looks weird in Phab here.
19491	.. and again here.

The patch has been committed: https://cgit.FreeBSD.org/src/commit/?id=02b885b09d1e90574162a1442b9ede06cef2b13a

tuexen added a commit: rG02b885b09d1e: tcp: fix TCP MD5 computation for the BBR and RACK stack.Jun 27 2023, 8:30 AM

tuexen added a commit: rGedff1d344c6b: tcp: fix TCP MD5 computation for the BBR and RACK stack.Jan 11 2024, 9:09 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

bbr.c

10 lines

rack.c

66 lines

Diff 123390

View Options

sys/netinet/tcp_stacks/bbr.c