zfs holds dataset@snapshot
zfs holds -r dataset@snapshot
zfs holds -r dataset
Nice work. I gauge this on style(9) rules (NULL used properly; '\0' used properly; proper comparison of pointer to NULL versus treating it as boolean; et cetera), validation of logic-reversal (== becomes !=), validation of removal of error message given context of change (allow dataset arguments as well as snapshots), and of course this change meets the goal of minimal-changes to reach desired effect.
Short of actually running the code myself, I'd say this patch looks dandy. [Again,] Nice work!
Updated with feedback from mahrens
add support for -d, to limit depth of search
add support for -p, to print values as literals (raw timestamp instead of date text)
update usage message
update man page
|275–278 ↗||(On Diff #9687)|
I think you should also add a detailed description of the new -H, -p, and -d flags. (feel free to copy/paste the descriptions from "zfs list").