Page MenuHomeFreeBSD
Differential D39890

amd64: store pcids pmap data in pcpu zone
ClosedPublic
Actions

Authored by kib on May 1 2023, 11:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 13, 1:43 PM
Unknown Object (File)
Dec 15 2025, 12:51 PM
Unknown Object (File)
Dec 14 2025, 3:32 PM
Unknown Object (File)
Dec 10 2025, 9:01 AM
Unknown Object (File)
Nov 1 2025, 9:09 AM
Unknown Object (File)
Nov 1 2025, 6:04 AM
Unknown Object (File)
Nov 1 2025, 4:41 AM
Unknown Object (File)
Nov 1 2025, 1:03 AM
View All Files
Subscribers
emaste
imp
mjg

Details

Reviewers
alc
markj
Commits
rG42f722e721cd: amd64: store pcids pmap data in pcpu zone
rG9c8cbf381985: amd64 pmap_pcid_alloc(): pass a pointer to struct pmap_pcid instead of cpuid
rG9e0143694ad3: amd64: add pmap_get_pcid() helper
rG86b61ccb34d4: amd64 pmap: add pmap_pinit_pcids() helper
rG32bb28d8ad31: amd64: move definition of the struct pmap_pcids into _pmap.h
Summary

This boots multiuser on Ivy.
Per-patch view is available at https://kib.kiev.ua/git/gitweb.cgi?p=deviant3.git;a=shortlog;h=refs/heads/maxcpu2

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.May 1 2023, 11:53 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 1 2023, 11:53 AM
kib requested review of this revision.May 1 2023, 11:53 AM
markj added inline comments.May 1 2023, 1:59 PM
sys/amd64/amd64/pmap.c
2031

Or just (void *)(uintptr_t)offsetof(struct pcpu, pc_kpmap_store)?

sys/amd64/include/_pmap.h
2

Missing a license header.

5

Why "pcids" instead of "pcid"?

sys/amd64/include/pmap.h
542–543
kib marked 4 inline comments as done.May 1 2023, 2:48 PM
kib added inline comments.
sys/amd64/include/_pmap.h
5

I do not remember why did I named it with 's'. Included the rename into the series.

kib updated this revision to Diff 121300.May 1 2023, 2:49 PM
kib marked an inline comment as done.

Rename pmap_pcids to pmap_pcid.
Simplify kernel pmap pcpu pointer calculation.
Add license.

markj accepted this revision.May 1 2023, 3:11 PM
This revision is now accepted and ready to land.May 1 2023, 3:11 PM
alc added inline comments.May 1 2023, 4:34 PM
sys/amd64/amd64/pmap.c
388–389
kib marked an inline comment as done.May 2 2023, 1:16 AM
Closed by commit rG32bb28d8ad31: amd64: move definition of the struct pmap_pcids into _pmap.h (authored by kib). · Explain WhyMay 2 2023, 11:40 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG32bb28d8ad31: amd64: move definition of the struct pmap_pcids into _pmap.h.
kib added a commit: rG86b61ccb34d4: amd64 pmap: add pmap_pinit_pcids() helper.
kib added a commit: rG9e0143694ad3: amd64: add pmap_get_pcid() helper.
kib added a commit: rG9c8cbf381985: amd64 pmap_pcid_alloc(): pass a pointer to struct pmap_pcid instead of cpuid.
kib added a commit: rG42f722e721cd: amd64: store pcids pmap data in pcpu zone.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
2 lines
include/
39 lines
8 lines

Diff 121376

View Options

sys/amd64/amd64/pmap.c

Loading...
View Options

sys/amd64/include/_pmap.h

Loading...
View Options

sys/amd64/include/pmap.h

Loading...