Page MenuHomeFreeBSD

inpcb: use family specific sockaddr argument for bind functions
ClosedPublic

Authored by glebius on Feb 15 2023, 2:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 8 2024, 8:55 AM
Unknown Object (File)
Jan 3 2024, 2:23 PM
Unknown Object (File)
Dec 20 2023, 5:02 AM
Unknown Object (File)
Sep 15 2023, 7:19 AM
Unknown Object (File)
Aug 17 2023, 3:43 PM
Unknown Object (File)
Jun 25 2023, 6:04 PM
Unknown Object (File)
Jun 5 2023, 5:35 AM
Unknown Object (File)
May 28 2023, 11:01 AM

Details

Summary

Do the cast from sockaddr to either IPv4 or IPv6 sockaddr in the
protocol's pr_bind method and from there on go down the call
stack with family specific argument.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei added a subscriber: zlei.

Looks good to me.

Finally, we're getting rid of nam. Nice!

markj added inline comments.
sys/netinet/in_pcb.c
904

BTW, we are not consistent about using struct in_addr vs. struct in_addr * vs. in_addr_t in inpcb interfaces. It would be nice to simplify that too.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 15 2023, 6:31 PM
This revision was automatically updated to reflect the committed changes.