inpcb: Release the inpcb cred reference before freeing the structure
ClosedPublic
Actions

Authored by markj on Feb 13 2023, 11:17 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 13, 11:57 PM

	Unknown Object (File)
	Nov 26 2024, 4:14 AM

	Unknown Object (File)
	Nov 26 2024, 4:14 AM

	Unknown Object (File)
	Nov 26 2024, 3:47 AM

	Unknown Object (File)
	Nov 23 2024, 6:42 PM

	Unknown Object (File)
	Nov 23 2024, 8:22 AM

	Unknown Object (File)
	Nov 22 2024, 11:41 AM

	Unknown Object (File)
	Nov 12 2024, 7:41 PM

Subscribers

Tokens

"Like" token, awarded by p.mousavizadeh_protonmail.com.

Details

Reviewers

glebius

Group Reviewers

network

Commits

rG5fd1a67e885e: inpcb: Release the inpcb cred reference before freeing the structure

Summary

Now that the inp_cred point is accessed only when the inpcb lock is
held, we can avoid deferring a crfree() call when freeing an inpcb.

Sponsored by: Klara, Inc.
Sponsored by: Modirum MDPay

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49755
Build 46645: arc lint + arc unit

Event Timeline

markj created this revision.Feb 13 2023, 11:17 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptFeb 13 2023, 11:17 PM

markj requested review of this revision.Feb 13 2023, 11:17 PM

Harbormaster completed remote builds in B49755: Diff 117158.Feb 13 2023, 11:17 PM

markj added a parent revision: D38572: inpcb: Avoid inp_cred dereferences in SMR-protected lookup.Feb 13 2023, 11:17 PM

markj added a child revision: D38574: netinet: Remove IP(V6)_BINDMULTI.

zlei added a subscriber: zlei.Feb 14 2023, 10:20 AM

dch added a subscriber: dch.Feb 16 2023, 10:35 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 20 2023, 4:14 PM

Closed by commit rG5fd1a67e885e: inpcb: Release the inpcb cred reference before freeing the structure (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG5fd1a67e885e: inpcb: Release the inpcb cred reference before freeing the structure.

p.mousavizadeh_protonmail.com awarded a token.Aug 7 2023, 7:15 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_pcb.c

23 lines

Diff 117158

View Options

inpcb: Release the inpcb cred reference before freeing the structureClosedPublicActions