Mk/bsd.port.mk: Be verbose when pkgconfig files ends up in wrong path

[diizzy]

Summary

While this is applied for convenience we shouldn't silently hide fixups

[diizzy]

Attach correct patch...

[diizzy]

Minor fix to message text

[tcberner]

Mk/bsd.port.mk

3542

I wonder whether it would make more sense to add it to DEV_WARNINGS and not to echo it manually.

[mat]

Mk/bsd.port.mk

3542

DEV_WARNINGS and WARNINGS are like, static things, that run before everything, they can't really know what will happen during staging.

[tcberner]

Mk/bsd.port.mk

3542

hm, then maybe manually check for the DEVELOPER mode?
I doubt there is much benefit in non-maintainers reading the message.

[diizzy]

Mk/bsd.port.mk

3542

I think it can be useful in general as this "silent fix" causes a different end result than what build log shows.

[diizzy]

Friendly ping

[diizzy]

Should this go in or is it deemed unnecessary?

[mat]

I can't seem to edit and propose a change for some reason, but, change it to something like this:

                    if [ -n "${DEVELOPER:Dyes}" ]; then \
			${ECHO_MSG} "===>   File(s) found in lib/pkgconfig while correct path is libdata/pkgconfig"; \
			${ECHO_MSG} "       Applying fix but consider using USES= pathfix or adjust install path"; \
                    fi; \

[diizzy]

Only display message when DEVELOPER variable is set as suggested by mat

[bofh]

[diizzy]

Commit af209cebad90f67199b65c0c1737f7d187498a12
Forgot to reference it, sorry